Fix crashes in Android builds #27840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- guarded checking of `RENDERER` option for non-Android builds; - guarded checking of `SOFTWARE_RENDERING` option for Android builds.
ZhilkinSerg
added
SDL: Tiles / Sound
|
I thought the Android port was dead, lol |
|
No we're trying to get it included in the main development tree so we can keep maintaining it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Fix crashes in Android builds"Purpose of change
Fix crashes in Android builds related to invalid option selection (see be1b069#commitcomment-32046261).
Describe the solution
RENDERERoption for non-Android builds;SOFTWARE_RENDERINGoption for Android builds.Describe alternatives you've considered
Put renderer selection to pre-game Java UI. I will probably proceed with this later.