Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android compile error #27757

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Trying to fix Android compile error reported here.

Describe the solution

Earlier include cleanup removed some headers important for the Android build. Attempt to restore them.

Additional context

Untested, because I don't have access to the relevant build environment. There might well be further issues in other files which become apparent after this one is fixed. Who is a good person to flag for Android testing?

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) OS: Android Issues related to Android operating system labels Jan 21, 2019
src/main.cpp Outdated Show resolved Hide resolved
Earlier include cleanup removed some headers important for the Android
build.  Attempt to restore them.
@ZhilkinSerg ZhilkinSerg merged commit 61b1fa2 into CleverRaven:master Jan 22, 2019
@jbytheway jbytheway deleted the fix_android_build branch January 22, 2019 09:44
@ZhilkinSerg
Copy link
Contributor

There is an unrelated issue which still prevents compiling Android version, but that's not because IWYU. It was brought in #27566 and is being addressed in #27735.

@jbytheway
Copy link
Contributor Author

Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments OS: Android Issues related to Android operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants