-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] IWYU support (part 6): Apply IWYU changes (take 2) #27713
Conversation
Again, Gorgon is complaining because of changes to |
Did IWYU get confused by the #ifdef RELEASE in tests/hash_test.cpp?
|
Yes; I ran in debug mode so it didn't account for uses in Will do some more prep and then return to this. |
89e5041
to
43c9848
Compare
7285de8
to
9b229f1
Compare
Turns out M_PI isn't standard C, it's POSIX. In particular, it's not present on Mingw. So we need to provide our own fallback definition.
Needed for GetUserDefaultLCID.
These are the changes made by running IWYU as described in DEVELOPER_TOOLING.md.
9b229f1
to
b62a9a8
Compare
I think this is now ready (finally got a green tick on the Travis CI), but it probably shouldn't get merged until post-0.D because it will lead to all sorts of annoying merge conflicts between master and the release branch. I'll return to it then. |
OK this has accumulated a massive list of conflicts, feel free to reopen when you have time and interest. |
Summary
SUMMARY: Infrastructure "Update header includes to include-what-you-use standards"
Purpose of change
To include what we use :).
Describe the solution
Three more commits with platform-specific fixes, followed by one big commit with the changes made by running IWYU as described in DEVELOPER_TOOLING.md, followed by astyle.
Additional context
Note that although IWYU does sort headers by category, it does not sort alphabetically within categories. I don't have a tool to do that, so things are now non-alphabetical.
Some blank lines have been introduced in places where we probably don't want them. If people feel strongly then I can tidy those up, but would prefer to do so in a separate PR.
This is quite likely to break the Android build.