Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically choose infinite sources for crafting when available #27319

Merged
merged 3 commits into from
Dec 27, 2018

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: Interface "Automatically choose infinite sources for crafting when available"

Purpose of change

When there is an infinite source of some material nearby, it makes sense to use that rather than other potential options.
Also, the UI was ugly when offering an infinite source, because it listed a huge integer number.

Describe the solution

Two changes:

  • When an infinite source is available on the map, don't offer the UI to choose an item to use; instead just pick the infinite one automatically.
  • When consuming charges from the map, always prefer infinite sources (the current behaviour is to use the closest source, even when an infinite source is available).

Describe alternatives you've considered

Could have kept current behaviour and just cleaned up the UI.

Additional context

There might be a performance impact since we're searching more tiles now when consuming charges from the map, but I hope crafting doesn't happen so often that's an issue.

It wasn't necessary to have both of them.
When crafting something that uses e.g. water and the map has infinite
charges of water, just use that without asking the player what to use.
When consuming charges from the map, it used to always consume the
closest available source.  Instead, always prefer infinite sources even
when not closest.
@Night-Pryanik
Copy link
Contributor

The only concern I have is whether the player will understand that the infinite source is used by default if no UI prompts appear.

@cainiaowu
Copy link
Contributor

add some feedback message to notify the player should be enough.

@jbytheway
Copy link
Contributor Author

jbytheway commented Dec 27, 2018

I don't feel that's necessary. It's already the case that e.g. if there were some plastic bottles of water nearby and a swimming pool then it would pick one semi-arbitrarily with no feedback. And that doesn't seem to cause much confusion.

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 27, 2018
@Rivet-the-Zombie Rivet-the-Zombie merged commit bec1d99 into CleverRaven:master Dec 27, 2018
@jbytheway jbytheway deleted the auto_choose_infinite branch December 27, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants