Fixes colors in note UI #26536
Merged
Fixes colors in note UI #26536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes colors in note UI"Purpose of change
Fixes issue with multi-colored description, mentioned in #25418.
Describe the solution
_()replaced withtranslate_marker()for color names. They already translated where needed.Describe alternatives you've considered
Alternative suggested by @Qrox in #25418: Maybe construct
note_color(value type ofcolor_by_string_map) with untranslated name and make two functionsname()andtag()which return the translated name and color tag respectively?Additional context
We should fix note editing issue in this input popup. Maybe create new class inherited from
string_input_popup, allowing dynamic update of the UI elements.