Clearer crafting search description #26452
Conversation
|
Build failures because master is broken right now. |
jbytheway
force-pushed
the
crafting_search_description
branch
from
b721924 to
7fbd822
Compare
|
Rebased on hopefully-fixed master. |
jbytheway
force-pushed
the
crafting_search_description
branch
from
7fbd822 to
7d1bf1f
Compare
mlangsdorf
added
Info / User Interface
|
I don't know if it's related to your change, but I got this result: |
Interesting. I'm guessing that's on curses? Didn't test curses. Will look into it. |
Try to present the options in a less confusing manner. Now each one has a single row, rather than a definition and an example somewhere else. Colour highlighting to draw out the important parts. Intended to be sorted roughly in decreasing order of how often you will want them. Fixes CleverRaven#26311.
jbytheway
force-pushed
the
crafting_search_description
branch
from
7d1bf1f to
c4ba469
Compare
|
It was a classic mistake in string constructor argument ordering. Unnoticed because the tiles build happens to render |
|
Soon after the last i18n-update (commit: 3e5c5a1) i found part of the 'german-crafting-search-help-window' - great work btw - already pretranslated. which imho could be very misleading, because you can't really search for h:ja / h:nein or m:ja / m:nein - at least one does not get any results out of those searches. Maybe in this particular case yes or no shouldn't be translatable. Alternatively they could be, if they would lead to the same results. Personally, i don't feel that either hidden nor memorized work very well as search-filters. Searching for h:no for example just shows what you are already seeing without even searching. hidden and memorized could be excellent toggles though. "Press h or H and you can toggle between hidden or none hidden recipes..." german-crafting-search-help-window -> post-3e5c5a1: |
Summary
SUMMARY: Interface "Clearer crafting search help window"
Purpose of change
The current help window for crafting search is confusing to newcomers. The special characters are presented in two ways, with the syntax away from the description.
Also, people generally try
qwhen they wantQ.Describe the solution
New window:
qandQ.I've implemented my own "align strings in columns of the correct width" code here, which perhaps already exists elsewhere, but I couldn't find it.
display_tabledoes something similar, but not the same.Fixes #26311.
Describe alternatives you've considered
We could have a better description without swapping
qandQ, but I really think they should be swapped.Additional context
I noticed that the keys used for searches are hardcoded and cannot be changed in translation. That may not be ideal, but that's not something I want to address here.