Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY]Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes #26285

Merged
merged 6 commits into from
Nov 4, 2018

Conversation

Regilith
Copy link
Contributor

@Regilith Regilith commented Oct 16, 2018

Summary

SUMMARY: Content "Adds and modifies 3L, regular, red sauce, and kompot canning recipes."

Purpose of change

Makes 3L jars more useful and versatile. Fix the canning recipes of some non-updated foods. Make the kompot recipe more realistic and versatile. Allow preservation of red sauce.

Describe the solution

Semi-resurrection of #22526

  • Add canning recipes for red sauce
  • Add 3L recipe variants for all canning and pickling recipes
  • Make base kompot recipe craft .5L portions instead of 3L portions
  • Add .5L canning recipe for kompot
  • Adjust kompot recipe to use more power (previously 2, which was lower than boiling water)
  • Adjust kompot recipe to use more sugar. 1 gallon of kompot calls for ~1 cup of sugar, which translates into 27g per .5L. 1 unit of sugar is 5g, so .5L should use ~5 units. It's an art, not a science. http://ukrainian-recipes.com/apple-kompot.html https://polishhousewife.com/kompot/
  • Adjust kompot recipe to use 50% more fruit, from 4 to 6. This is both more realistic, and to make it a multiple of 6.
  • Adjust kompot calories to account for increased sugar and fruit. 1 apple (~100 kcal) + 25g sugar (97 kcal) = 197 kcal, or rounded to 200 kcal per .5L portion to reflect the wide variety of ingredients able to be used to make kompot. A single portion is 250ml, or ~100 kcal.
  • Update some other canning recipes to include use of canning pot, which I missed in [RDY] Replaces vacuum sealer requirements on sealed glass jar recipes with canning pot, to simulate water bath method #25661 because they didn't use the vacuum sealer for some reason. The previous lack of any canning method in these recipes was probably an oversight. The list includes: canned offal, canned meat, canned fish, canned human, canned veggy, canned fruit, canned veggy soup, canned tomato.
  • Add 3L foods to kitchen and canned droplist

@Regilith Regilith changed the title Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes [WIP] Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes Oct 17, 2018
@Regilith
Copy link
Contributor Author

Regilith commented Oct 17, 2018

This PR involves a lot of numbers balancing, so I'd appreciate it if someone gave it a once-through to make sure I didn't miss anything.

I decided to abstract the power usage of canning to 100 per .5L jar, and 200 per 3L jar for the following reasons:

  • To purify 1 unit of water via boiling, it takes 5 minutes and 3 power. Water bath canning involves cooking the food, getting the water to a boil, and maintaining boil for ~10 minutes for .5L and ~25 minutes for 3L (larger jar means longer time to sterilize)
  • I'm assuming the survivor maintains temperature when they boil water (as I do at home), so maintaining a boil would take 9/18 power per unit of water for .5L/3L jars, respectively. As the survivor is boiling 10 water, that power usage goes to 90 and 180.
  • Add in the fact that all the power requirements for cooking the non-sealed variants of these foods adds an additional ~2-30 power, the costs would be around 92-120 and 182-210, so I decided to simplify the power costs to 100/200 for easier maintenance.

I changed the id_suffix of the 3L kompot recipe to keep inline with the other 3L recipes, which hopefully shouldn't break anything. I played a world before this PR, spawned a 3L jar of kompot, quit the world and applied the update, and the 3L jar remained the same and was usable.

This may change sealed jar spawns (whether they spawn in .5L or 3L jars in world, if applicable). I need to add canned red sauce to the drop list, as well as perhaps some other 3L drops.

I removed the ["result_mult": 12] from the 3L jars as they seemed to spawn with the correct amounts without it. If this was wrong, let me know.

All non-bone 3L recipes take 40 minutes (15 cook + 25 boil), bone 3L recipes take 70 minutes (45 cook + 25 boil)(base bone broth recipe takes only 6 power for a 1 hour recipe. If you would like to see an adjustment, let me know), and the red sauce recipe takes 120 minutes (you can technically make it in only 20 minutes, but if you want to make the real stuff, you gotta let it simmer for an hour or two)

Pickling .5L jars takes 20 power. I made pickling 3L take 100 power. Not sure why the heat requirement for pickling is so high.

Going through the power requirements of various foods, a lot of them seem arbitrary and nonsensical, probably for balancing reasons. Stuff like boiling water for 5 minutes takes 3 power, but making bone broth over an hour only requires 6. If my suggested power requirements seem a little high compared to the rest of the recipes, let me know. The old power requirements for 3L kompot was 2 for cooking and 10 for vac sealing, with similar requirements for the rest of the old vacuum-sealed jar recipes, so these changes represent a significant nerf, which may warrant discussion.

@Regilith Regilith changed the title [WIP] Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes [WIP][CR] Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes Oct 17, 2018
@Regilith
Copy link
Contributor Author

Aside for the aforementioned discussion on whether 100/200 power for canning is acceptable balance-wise, constituting a significant nerf compared to the previous vacuum sealing power component, this should be ready for review.

@Regilith Regilith changed the title [WIP][CR] Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes Oct 19, 2018
@kwl01skz
Copy link
Contributor

By the way, Compared to the 【canned offal】, the 【pickled offal】 has no advantage, but consumes more material and requires more skill.

@Rivet-the-Zombie
Copy link
Member

Pickled offal is supposed to have a better fun value than the basic canned stuff.

@Regilith
Copy link
Contributor Author

Regilith commented Oct 22, 2018

That's probably outside the scope of this PR. If anything, pickled offal got buffed compared to canned because the power requirements for canning are much higher than before.

@Regilith
Copy link
Contributor Author

Regilith commented Oct 22, 2018

Jenkins, rebuild

@mlangsdorf mlangsdorf added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 22, 2018
@Regilith Regilith changed the title Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes [RDY]Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes Nov 1, 2018
@ZhilkinSerg ZhilkinSerg self-assigned this Nov 4, 2018
@ZhilkinSerg ZhilkinSerg merged commit 48e15c2 into CleverRaven:master Nov 4, 2018
@ZhilkinSerg ZhilkinSerg removed their assignment Nov 4, 2018
@l29ah
Copy link
Contributor

l29ah commented Nov 12, 2018

I've made 3L worth of pickled meats, but only got one meat in the jar.

l29ah added a commit to l29ah/Cataclysm-DDA that referenced this pull request Nov 12, 2018
@Regilith Regilith deleted the Add-3L-recipes branch September 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants