-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDY]Add 3L jar canning and pickling recipes, add canned red sauce, update kompot, update some missed .5L canning recipes #26285
Conversation
This PR involves a lot of numbers balancing, so I'd appreciate it if someone gave it a once-through to make sure I didn't miss anything. I decided to abstract the power usage of canning to 100 per .5L jar, and 200 per 3L jar for the following reasons:
I changed the id_suffix of the 3L kompot recipe to keep inline with the other 3L recipes, which hopefully shouldn't break anything. I played a world before this PR, spawned a 3L jar of kompot, quit the world and applied the update, and the 3L jar remained the same and was usable. This may change sealed jar spawns (whether they spawn in .5L or 3L jars in world, if applicable). I need to add canned red sauce to the drop list, as well as perhaps some other 3L drops. I removed the ["result_mult": 12] from the 3L jars as they seemed to spawn with the correct amounts without it. If this was wrong, let me know. All non-bone 3L recipes take 40 minutes (15 cook + 25 boil), bone 3L recipes take 70 minutes (45 cook + 25 boil)(base bone broth recipe takes only 6 power for a 1 hour recipe. If you would like to see an adjustment, let me know), and the red sauce recipe takes 120 minutes (you can technically make it in only 20 minutes, but if you want to make the real stuff, you gotta let it simmer for an hour or two) Pickling .5L jars takes 20 power. I made pickling 3L take 100 power. Not sure why the heat requirement for pickling is so high. Going through the power requirements of various foods, a lot of them seem arbitrary and nonsensical, probably for balancing reasons. Stuff like boiling water for 5 minutes takes 3 power, but making bone broth over an hour only requires 6. If my suggested power requirements seem a little high compared to the rest of the recipes, let me know. The old power requirements for 3L kompot was 2 for cooking and 10 for vac sealing, with similar requirements for the rest of the old vacuum-sealed jar recipes, so these changes represent a significant nerf, which may warrant discussion. |
Aside for the aforementioned discussion on whether 100/200 power for canning is acceptable balance-wise, constituting a significant nerf compared to the previous vacuum sealing power component, this should be ready for review. |
By the way, Compared to the 【canned offal】, the 【pickled offal】 has no advantage, but consumes more material and requires more skill. |
Pickled offal is supposed to have a better fun value than the basic canned stuff. |
That's probably outside the scope of this PR. If anything, pickled offal got buffed compared to canned because the power requirements for canning are much higher than before. |
Jenkins, rebuild |
I've made 3L worth of pickled meats, but only got one meat in the jar. |
Summary
SUMMARY: Content "Adds and modifies 3L, regular, red sauce, and kompot canning recipes."
Purpose of change
Makes 3L jars more useful and versatile. Fix the canning recipes of some non-updated foods. Make the kompot recipe more realistic and versatile. Allow preservation of red sauce.
Describe the solution
Semi-resurrection of #22526