vehicle mounted pet carriers #24391

mlangsdorf · 2018-07-20T14:32:40Z

adds the infrastructure to support vehicle mounted pet carriers, and creates a new part, the livestock
carrier, that can be installed on a vehicle as a livestock stall and used as a vehicle mounted pet carrier.

create a new iuse, capture_monster_veh, which acts like capture_monster_act but only for vehicle mounted items. add the code to pickup.cpp and vehicle.cpp to recognize vehicle parts with the CAPTURE_MONSTER_VEH flag and provide menu options to use them that then invoke capture_monster_veh.

add a new vehicle part, the livestock carrier, that can be installed as a livestock stall. livestock stalls can be used to capture creatures up to LARGE size.

mlangsdorf · 2018-07-20T14:38:41Z

Still to do (possibly in another PR):

Add weight of carried animal to vehicle/remove it when removed.
Remove cargo capacity when an animal is in the stall.
Make loading or unloading an animal into a long action taking 5-10 minutes.
Add support for transporting large robots.

tinukedaya · 2018-07-20T16:58:58Z

I like this! But I would not say it fixes #11381

It's very good and realistic approach for transport of large animals. But cats and dogs should be able to just be with you inside the car, without the need to put them to the stall (just like NPCs). For the small ones it still feels like a workaround, same as using Pet Carrier. Personally I just don't get any dogs anymore, even tho' I'd like to, they always ended up closed in the carrier, because it's just too much hassle to work with.

BTW: I know this is a long stretch, but any chance this could be adapted to transport small vehicles? Bike rack, anyone? Or fork-lifter plugged at the back of my truck?
Or maybe just one tile "garage" for the shopping cart, pallet lifter, or portable generator. I hate to always build the pallet lifter when I need to reinstall some storage batteries.

mlangsdorf · 2018-07-20T17:43:07Z

okay, it doesn't fix #11381. Fair enough. I am not currently up to untangling the NPC code that lets them ride in a vehicle enough to apply it to friendly monsters, though, so this is the work-around for now.

Repurposing this for vehicle racks: haha - wait, that might almost work.

So the monster capture routine works, in part, by grabbing the json description of the monster being captured and stashing it in the pet carrier, and then using that description to spawn a new monster with the exact same statistics when the pet carrier is emptied.

vehicles are described by json, there's no reason in principle that you couldn't do the same. Handling collisions would be challenging, but not impossible.

I want to do a rework of how actions are handled for vehicle parts in general, but it's possible that a vehicle rack could come out of that. Beyond the scope of this PR, though.

By the way, pallet lifters and telescopic cantilevers/telescoping cranes are foldable, you can build them on a folding frame with a unicycle wheel or castors and fold them up when not in use. The existing engine crane vehicle is exactly that design. So you don't need to rebuild a pallet lifter every time you want to scavenge a storage battery.

Still, it would be great to be able to transport ATVs on trucks and such.

ZhilkinSerg · 2018-07-20T21:48:44Z

Cannot capture friendly chicken

mlangsdorf · 2018-07-21T00:18:21Z

You're selecting the tile with the chicken in it? Because you're clearly within the iuse::capture_monster_act code, so you're failing the check:

if( const monster *const mon_ptr = g->critter_at<monster>( target ) ) {

which means you're aiming it at nothing.

I'll look at it more on Monday, but that's a weird failure mode because it's failing within the part of the code that I didn't change.

mlangsdorf · 2018-07-23T12:43:03Z

Okay, I summoned a chicken and fed it birdfood to make it friendly.

I examined the tile on my vehicle with the livestock stall

then I selected the tile to the east. Didn't capture the chicken. Repeated the process, but selected the tile to the NE. Captured the chicken, and can see I have a chicken in the livestock stall.

then I examined the tile again and released the critter.

So I really can't reproduce your failure and I suspect you selected the wrong tile in your test.

AMurkin · 2018-07-23T13:02:49Z

Suggestion: add option to transfer pet from/to regular pet carrier.

ZhilkinSerg · 2018-07-23T14:18:17Z

So I really can't reproduce your failure and I suspect you selected the wrong tile in your test.

I guess I know what was wrong in my test - I've pressed key to select tile relative to vehicle part position instead of player position. Will try to test again tonight.

mlangsdorf · 2018-07-23T15:09:29Z

Yes, it's position relative to the player. Thanks for the retest.

Night-Pryanik · 2018-07-23T18:54:33Z

src/vehicle.cpp

+    parts[part].set_base( base );
+    /* captured animals take up all the cargo space */
+    /*
+    if( base.has_var( "contained_name" ) ) {


I guess this commented text should be deleted.

Night-Pryanik · 2018-07-23T18:54:47Z

doc/JSON_FLAGS.md

@@ -467,6 +467,7 @@ These branches are also the valid entries for the categories of `dreams` in `dre
 - ```BOARDABLE``` The player can safely move over or stand on this part while the vehicle is moving.
 - ```CAMERA```
 - ```CAMERA_CONTROL```
+- ```CAPTURE_MOSNTER_VEH``` Can be used to capture monsters when mounted on a vehicle.


What's the typo? I'm not seeing it.

mlangsdorf · 2018-07-24T16:28:32Z

@ZhilkinSerg #24462 expands the description of the livestock stall to make it clear you select the animal relative to the PC, not to the vehicle part.

mlangsdorf added 2 commits July 20, 2018 09:38

vehicle: add livestock stall and livestock carrier

223e2ac

add a new vehicle part, the livestock carrier, that can be installed as a livestock stall. livestock stalls can be used to capture creatures up to LARGE size.

mlangsdorf force-pushed the veh_pet_carrier branch from 18228d2 to 223e2ac Compare July 20, 2018 14:38

mlangsdorf mentioned this pull request Jul 20, 2018

Farming Improvements: QoL issues that need solving #24294

Open

ZhilkinSerg self-assigned this Jul 20, 2018

ZhilkinSerg removed their assignment Jul 20, 2018

ZhilkinSerg added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact labels Jul 20, 2018

ZhilkinSerg self-assigned this Jul 23, 2018

ZhilkinSerg merged commit ce32af5 into CleverRaven:master Jul 23, 2018

ZhilkinSerg removed their assignment Jul 23, 2018

Night-Pryanik reviewed Jul 23, 2018

View reviewed changes

mlangsdorf deleted the veh_pet_carrier branch July 24, 2018 11:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vehicle mounted pet carriers #24391

vehicle mounted pet carriers #24391

mlangsdorf commented Jul 20, 2018 •

edited

Loading

mlangsdorf commented Jul 20, 2018 •

edited

Loading

tinukedaya commented Jul 20, 2018

mlangsdorf commented Jul 20, 2018 •

edited

Loading

ZhilkinSerg commented Jul 20, 2018

mlangsdorf commented Jul 21, 2018

mlangsdorf commented Jul 23, 2018

AMurkin commented Jul 23, 2018

ZhilkinSerg commented Jul 23, 2018

mlangsdorf commented Jul 23, 2018

Night-Pryanik Jul 23, 2018

Night-Pryanik Jul 23, 2018

mlangsdorf Jul 23, 2018

Night-Pryanik Jul 23, 2018

mlangsdorf commented Jul 24, 2018

vehicle mounted pet carriers #24391

vehicle mounted pet carriers #24391

Conversation

mlangsdorf commented Jul 20, 2018 • edited Loading

mlangsdorf commented Jul 20, 2018 • edited Loading

tinukedaya commented Jul 20, 2018

mlangsdorf commented Jul 20, 2018 • edited Loading

ZhilkinSerg commented Jul 20, 2018

mlangsdorf commented Jul 21, 2018

mlangsdorf commented Jul 23, 2018

AMurkin commented Jul 23, 2018

ZhilkinSerg commented Jul 23, 2018

mlangsdorf commented Jul 23, 2018

Night-Pryanik Jul 23, 2018

Choose a reason for hiding this comment

Night-Pryanik Jul 23, 2018

Choose a reason for hiding this comment

mlangsdorf Jul 23, 2018

Choose a reason for hiding this comment

Night-Pryanik Jul 23, 2018

Choose a reason for hiding this comment

mlangsdorf commented Jul 24, 2018

mlangsdorf commented Jul 20, 2018 •

edited

Loading

mlangsdorf commented Jul 20, 2018 •

edited

Loading

mlangsdorf commented Jul 20, 2018 •

edited

Loading