Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe vehicle parts Part 1a #24281

Merged
merged 5 commits into from
Jul 14, 2018

Conversation

mlangsdorf
Copy link
Contributor

Part 1a in a multi-step process to enhance the vehicle construction menu, similar to "Construction Menu UI enhancements #24105".

Add descriptions for all the vehicle parts. The descriptions are intended to be functional and give some indication of why you would want to install a particular part and sometimes where you would to install it.

Part 1b will add similar descriptions to the Blazemod parts.

Parts 2+ will change the vehicle interaction screen to display the descriptions, along with some of the other data from the JSON. I'd like to at least expose epower and LIFT and JACK qualities if I can. I definitely want to indicate the location field.

I expect the descriptions will generate some discussion, so I want to get them accepted before I move on.

Add descriptions for the vehicle parts, as they are installed on the
vehicle, instead of as vehicle components.

A future commit will display this description in the vehicle
interaction screen.
minor cleanups before adding descriptions
Add descriptions for the vehicle parts, as they are installed on the
vehicle, instead of as vehicle components.

A future commit will display this description in the vehicle
interaction screen.
@Night-Pryanik
Copy link
Contributor

Some of the vehicle parts are just variants of each other, like handle or wooden handle, so their description is identical. I wonder if adding them some flag and then describing this flag in flags.json would be a cleaner solution? Though this of course means much more work than simple filling the description field.

@mlangsdorf
Copy link
Contributor Author

That's a good suggestion.
What I would prefer to do is get the text of descriptions worked out in this PR.
A future PR will add displaying the descriptions and parsing the flags.
After that PR is complete, then I would be ready to refactor the common text into flags in another PR.

@Night-Pryanik
Copy link
Contributor

Ok then. The one last thing I want to mention is two spaces after periods inside the sentences.

@@ -28,6 +30,7 @@
"copy-from": "clothboard",
"type": "vehicle_part",
"name": "cloth quarterpanel",
"description": "A half-height cloth wall. Keeps zombies outside the vehiclebut allows people to see over it.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a space here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You fixed the double spacing, but I was actually talking about the typo ("vehiclebut"). I probably should have clarified after Night-Pryanik's comment. Looks like the same typo got copy-pasta'd several times as well, including a few I missed last night

@@ -36,6 +39,7 @@
"copy-from": "board",
"type": "vehicle_part",
"name": "quarterpanel",
"description": "A half-height metal wall. Keeps zombies outside the vehiclebut allows people to see over it.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ZhilkinSerg ZhilkinSerg added Translation I18n [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Jul 12, 2018
@mlangsdorf
Copy link
Contributor Author

Spaces added, as per the style manual.

@ZhilkinSerg ZhilkinSerg merged commit 340fb96 into CleverRaven:master Jul 14, 2018
@mlangsdorf
Copy link
Contributor Author

part 2: #24328

@mlangsdorf mlangsdorf deleted the describe_vehicle_parts branch July 23, 2018 12:22
@mlangsdorf
Copy link
Contributor Author

Better descriptions for some parts, display descriptions for installed parts #24462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Translation I18n Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants