-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe vehicle parts Part 1a #24281
Describe vehicle parts Part 1a #24281
Conversation
Add descriptions for the vehicle parts, as they are installed on the vehicle, instead of as vehicle components. A future commit will display this description in the vehicle interaction screen.
minor cleanups before adding descriptions
Add descriptions for the vehicle parts, as they are installed on the vehicle, instead of as vehicle components. A future commit will display this description in the vehicle interaction screen.
Some of the vehicle parts are just variants of each other, like handle or wooden handle, so their description is identical. I wonder if adding them some flag and then describing this flag in |
That's a good suggestion. |
Ok then. The one last thing I want to mention is two spaces after periods inside the sentences. |
data/json/vehicleparts/boards.json
Outdated
@@ -28,6 +30,7 @@ | |||
"copy-from": "clothboard", | |||
"type": "vehicle_part", | |||
"name": "cloth quarterpanel", | |||
"description": "A half-height cloth wall. Keeps zombies outside the vehiclebut allows people to see over it.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You fixed the double spacing, but I was actually talking about the typo ("vehiclebut"). I probably should have clarified after Night-Pryanik's comment. Looks like the same typo got copy-pasta'd several times as well, including a few I missed last night
data/json/vehicleparts/boards.json
Outdated
@@ -36,6 +39,7 @@ | |||
"copy-from": "board", | |||
"type": "vehicle_part", | |||
"name": "quarterpanel", | |||
"description": "A half-height metal wall. Keeps zombies outside the vehiclebut allows people to see over it.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Spaces added, as per the style manual. |
part 2: #24328 |
Better descriptions for some parts, display descriptions for installed parts #24462 |
Part 1a in a multi-step process to enhance the vehicle construction menu, similar to "Construction Menu UI enhancements #24105".
Add descriptions for all the vehicle parts. The descriptions are intended to be functional and give some indication of why you would want to install a particular part and sometimes where you would to install it.
Part 1b will add similar descriptions to the Blazemod parts.
Parts 2+ will change the vehicle interaction screen to display the descriptions, along with some of the other data from the JSON. I'd like to at least expose epower and LIFT and JACK qualities if I can. I definitely want to indicate the location field.
I expect the descriptions will generate some discussion, so I want to get them accepted before I move on.