[READY] I at overhaul MK II

[kevingranade]

This implements BevapDin's suggestion of a wrapper class that allows callers to modify items on the map easily without exposing direct access to the underlying container.
It got completely out of control, now each submap and vehicle maintains a list of iterators to their active items and iterates across that instead of across every item.

fixes #9917
Addresses some of #10269 (shouldn't trigger auto-close of the other issue)

[kevingranade]

Found some bugs, boo.
Specifically I messed up building rotation.

[kevingranade]

Fixed building rotation and tiles builds, but I want to hold off for more testing before marking this ready to go, I'll probably just push on to adding the active item optimizations then test that a lot.

[BevapDin]

This loop does not seem to change i, the condition i == index will never be fulfilled except when the first item is to be erased.

[kevingranade]

There are still some bugs here, and I need to rebase, but this is getting VERY CLOSE now.

[kevingranade]

Sole remaining issue, I totally hosed radio item processing. I'll give it the same treatment as active items. It should be easy now that all the infrastructure is in place.

[kevingranade]

Actually tested radio controlled items, and while their performance hasn't been enhanced like active items, they are still functional, so I'm going to call it there. Rebase incoming, which should be good to go.

[KA101]

KA101 debugports to Berlin

[KA101]

OK. So far, takes about a wall-clock second per DDA minute to long-action or sleep. Got an evac shelter full of active crap (chunks of meat, tainted/OK, melons, lightstrips) and some non-active stuff (Linux t-shirts, logs). Scent is on, doors are boarded.

Long-actioned and slept downstairs, free of active items: long actions were completed in about 5 seconds and sleeping took three seconds to process half an hour: roughly 10x faster.

Sorry, Kevin. :'-(

[kevingranade]

How's that compare to before the change? We're not talking infinite speed here, just a speedup.

[KA101]

I know. Not much of a speedup on this end: at best, marginal lag reduction in walking around and elimination of an additional lag burst whenever lying down to sleep. :-/

Long actions in the master (before your merge), with items, about 1:1 wall-second:DDA minute, but with a five-second lag between hitting A and DDA acknowledging the action. Sleeping with items, 10-second lag to lie down, then 30-33 seconds per half-hour cycle with distinct pause for updating sound marks, then updating clock and character status.

[kevingranade]

Ok, the tests where it was showing the most benefit had relatively small amounts of active items (e.g. rotting food) nearby, and relatively large amounts of inactive items, I'm guessing you're testing with the opposite. I don't know for sure which is more typical, but the case where there are not that many active items shows a gigantic benefit here.

There's an additional change I'm planning on making to specifically target rotting food, but this all is a precondition for it anyway. If your testing indicates this works correctly, please consider landing this, and I can pick up from there for the next set of changes.

[KA101]

Yeah, it's the opposite here, thousands of active items processing away. Had somehow thought you'd managed to secure 'em en masse.

8,000 charges of melon is not typical (100 each tainted/OK meat might be), so yeah. I'll give this a final test-compile and merge it.