Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when changing and saving tile options #6372

Closed
vidarsk opened this issue Mar 1, 2014 · 1 comment · Fixed by #6378
Closed

Crash when changing and saving tile options #6372

vidarsk opened this issue Mar 1, 2014 · 1 comment · Fixed by #6378
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Info / User Interface Game - player communication, menus, etc.

Comments

@vidarsk
Copy link
Contributor

vidarsk commented Mar 1, 2014

0.9 gf1e6f6b
SDL
Ubuntu 13.10

Changing either of the two options "Options->Graphics->Use tiles" or "Options->Graphics->Choose tileset" causes the game to crash after exiting options and pressing 'Y' to save the options. Settings are saved and take effect normally if game is restarted. Backtrace is:

(gdb) bt
#0 0x0830d743 in map::has_flag_ter_or_furn (this=0xb54bc0bc, flag=TFLAG_INDOORS, x=0, y=0) at src/map.cpp:1283
#1 0x08323618 in map::build_outside_cache (this=0xb54bc0bc) at src/map.cpp:4413
#2 0x08323a77 in map::build_map_cache (this=0xb54bc0bc) at src/map.cpp:4481
#3 0x0818cfaa in game::draw_ter (this=0xb54bc008, posx=0, posy=0) at src/game.cpp:4809
#4 0x0818bf5e in game::draw (this=0xb54bc008) at src/game.cpp:4671
#5 0x0818def5 in game::refresh_all (this=0xb54bc008) at src/game.cpp:4905
#6 0x08506a8f in show_options (ingame=false) at src/options.cpp:982
#7 0x082f4dfd in game::opening_screen (this=0xb54bc008) at src/main_menu.cpp:306
#8 0x082f2d26 in main (argc=0, argv=0xbffff598) at src/main.cpp:144
@Zireael07
Copy link
Contributor

I thought it was a function and not a crash!

kevingranade added a commit to kevingranade/Cataclysm-DDA that referenced this issue Mar 2, 2014
@kevingranade
Only refresh after changing tilesets in the option menu if we're call…
2d2a591 
…ed from in the game. Fixes CleverRaven#6372.
@kevingranade kevingranade mentioned this issue Mar 2, 2014
Merged
BevapDin added a commit to BevapDin/Cataclysm-DDA that referenced this issue Jul 13, 2014
@BevapDin
Merge remote-tracking branch 'upstream/master' into other-crafting-ap…
d6af5cb 
…proch

# By Chase (11) and others
# Via KA101 (9) and others
* upstream/master: (40 commits)
  Fix makefile version extraction logic to handle alpha characters.
  Final update to changelog, version fallbacks, motd, and credits before release.
  Only refresh after changing tilesets in the option menu if we're called from in the game. Fixes CleverRaven#6372.
  Category fix for two recipes.
  Adds tent_kit to dead-soldier itemgroup
  add debug function to remove all monsters
  Import translations from launchpad.
  Return a default name from name generator instead of crashing if no names are available.
  More item category fixes.
  fix for CleverRaven#6360
  Re-categorizes some shell casings as 'spare parts' instead of 'ammunition'.
  Update .pot
  Deletes unused variable
  Adds check for active first-aid
  Removes superfluous EATEN_HOT tag from peanut butter sammiches.
  Truncate item descriptions so they don't overflow into the inventory status display. Fixes CleverRaven#6358.
  Extract a magic number to a const.
  Fixes silly materials-based sock/shoe check.
  Small changes to HoderTileset to demonstrate tile category fallback behavior.
  Fallback categories for tile drawing.
  ...

Conflicts:
	Makefile
	data/json/items/melee.json
	src/inventory.cpp
	src/map.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only refresh after changing tilesets in the option menu kevingranade/Cataclysm-DDA
3 participants
@KA101 @Zireael07 @vidarsk