Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect crater map extra generation #59781

Closed
GuardianDll opened this issue Jul 31, 2022 · 4 comments
Closed

Incorrect crater map extra generation #59781

GuardianDll opened this issue Jul 31, 2022 · 4 comments
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@GuardianDll
Copy link
Member

GuardianDll commented Jul 31, 2022

Describe the bug

Sometimes the game spawn bomb on the edge of the overmap tile, and it cant interact with not loaded adjacent overmap tile correctly
(#59717 may be related for this)

Steps to reproduce

Walk on the map
find sometimes craters spawns incorrectly

Expected behavior

Correct crater spawn

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.1826 (21H2)
  • Game Version: 3b41d64 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Massachusetts [MA],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Magiclysm [magiclysm],
    Mythical Martial Arts [MMA],
    Xedra Evolved [xedra_evolved]
    ]
@GuardianDll GuardianDll added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jul 31, 2022
@Night-Pryanik
Copy link
Contributor

The most easiest solution is to place bomb in the center of OMT. This will work for medium-power bombs (such as on crater map extra), with explosion radius not crossing the boundaries of OMT. Consequently, this solution won't work for high-power bombs, as even one bomb with enough destructive power can have very big explosion radius which will cross the boundaries of OMT.

The proper solution would be to rework explosion mechanic so it can handle crossing the boundaries of OMT.

@NetSysFire NetSysFire added <Bug> This needs to be fixed (P5 - Long-term) Long-term WIP, may stay on the list for a while. Map / Mapgen Overmap, Mapgen, Map extras, Map display and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Sep 12, 2022
@Procyonae
Copy link
Contributor

I don't think this is anything to do with the explosion mechanic as such it's just that the crater bomb goes off at the edge of your reality bubble so the other OMT isn't loaded, if you just spawn bombs in they work fine over OMT and even 180x180 OM tile borders.

Procyonae added a commit to Procyonae/Cataclysm-DDA that referenced this issue Jun 28, 2023
…d over the whole OMT randomly

Works fine but CleverRaven#59781 means it looks bad
@Procyonae
Copy link
Contributor

Procyonae commented Jun 30, 2023

Ok scrap that there's something weirder going on I'm getting square edges consistently without them even crossing any OM boundary
image
Edit: It loads in in 12x12 submaps so it can't even cross those, specifically spawning in the middle of the 24x24 actually makes it more likely to cause this issue not less

Procyonae added a commit to Procyonae/Cataclysm-DDA that referenced this issue Jun 30, 2023
…d over the whole OMT randomly

Works fine but CleverRaven#59781 means it looks bad
dseguin pushed a commit that referenced this issue Jul 2, 2023
* Initial commit

* Fills one type of gap

* Backup before I change course

* New method spawning entire craters overlapping

* Spawn craters adjacent instead to take up less room

* Considered making crater bombs fall from above so they could be placed over the whole OMT randomly

Works fine but #59781 means it looks bad

* Revert "Considered making crater bombs fall from above so they could be placed over the whole OMT randomly"

This reverts commit 139cd1e.

* Testing wibbly wobbly craters

* Revert "Testing wibbly wobbly craters"

This reverts commit 99335b0.

* Splits nests so they don't interfere negatively

Removes wreckage bc it's just a weird item group that doesn't make much sense

* remove_vehicles

* Unhardcoding I missed

* Small crater

* Makes mutable file more sensible

* Corrected and added a couple of phase variants

* Added new distibution stuff and reduced check location area to match min size

* Added new distibution stuff and reduced check location area to match min size

* Updates the docs so they don't reference the old version

* Removes innawoods crater.json

Only appears to exist to remove the radioactivity and that's been removed from the vanilla crater anyway
@Brambor
Copy link
Contributor

Brambor commented Aug 20, 2024

@Brambor Brambor closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

No branches or pull requests

5 participants