Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Overriding of Vitamins By Mods #49165

Closed
Theawesomeboophis opened this issue Jun 3, 2021 · 6 comments
Closed

Allow Overriding of Vitamins By Mods #49165

Theawesomeboophis opened this issue Jun 3, 2021 · 6 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing Items: Food / Vitamins Comestibles and drinks Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mods Issues related to mods or modding stale Closed for lack of activity, but still valid.

Comments

@Theawesomeboophis
Copy link
Contributor

Theawesomeboophis commented Jun 3, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Mods are currently unable to overide vitamins, this is something I noticed after Kenan2000/CDDA-Structured-Kenan-Modpack#87 was merged.

Describe the solution you'd like

I would like the ability for mods to override vitamins.

Describe alternatives you've considered

Leaving it as it is, but I believe adding this will be beneficial to current and future mods.
@Theawesomeboophis Theawesomeboophis changed the title Allow Overiding of Vitamins Allow Overriding of Vitamins Jun 3, 2021
@Theawesomeboophis Theawesomeboophis changed the title Allow Overriding of Vitamins Allow Overriding of Vitamins By Mods Jun 3, 2021
@actual-nh actual-nh added <Enhancement / Feature> New features, or enhancements on existing Items: Food / Vitamins Comestibles and drinks Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mods Issues related to mods or modding labels Jun 3, 2021
@actual-nh
Copy link
Contributor

The update didn't remove the deficiencies, actually, which weren't functional - it removed their sending incorrect messages. Or is this other mod for actually having the deficiencies or something? (Ping: @Venera3)

@Theawesomeboophis
Copy link
Contributor Author

PK's Rebalancing actually makes the deficiencies for these vitamins have gameplay effects.

@Theawesomeboophis
Copy link
Contributor Author

And removing them from the vitamins in vanilla led to the deficiencies in the mod not working, hence why the above PR was submitted to kenan's modpack.

@Theawesomeboophis
Copy link
Contributor Author

The PR above led to a bug in PK's Rebalancing due to the game not allowing for the overwriting of vitamins.

@stale
Copy link

stale bot commented Apr 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Apr 29, 2022
@Night-Pryanik
Copy link
Contributor

Closing as stale, since stalebot can't do this by itself.

@Night-Pryanik Night-Pryanik closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Enhancement / Feature> New features, or enhancements on existing Items: Food / Vitamins Comestibles and drinks Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mods Issues related to mods or modding stale Closed for lack of activity, but still valid.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Night-Pryanik @Theawesomeboophis @actual-nh