Autopickup lag when moving past tiles with many items

[Funguss]

Updated, issue was due to autopickup.

It seems that having many items in a tile causes lag when moving past it. This is unrelated to #37554 as there aren't any maps in my piles. I'm using 4x monster spawns and am trying to keep things tidy, but massive piles of dirty clothes and misc loot are causing me to hoard (as I don't want to even approach them!). I'm half inclined to think part of this is my rig being slow, but I doubt that's the full story, or even part of it.

Edit: There seemed to be a reduction in lag when my PC was nude and wandering through the mess. I'm not sure if this is actually the case or if it's my imagination.

Edit 2: Here's the save Edit 3: Here is the actual save. 😕 Bentonia.zip

Steps To Reproduce

1. Dump thousands of litres of small junk items in one area.
2. Try walking about in it.

Versions and configuration

• OS: Windows
  • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
• Game Version: 0.D-12504-g9015618 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Aftershock [aftershock],
  C.R.I.T Expansion Mod [crt_expansion],
  Magiclysm [magiclysm],
  Makeshift Items Mod [makeshift],
  More Survival Tools [More_Survival_Tools],
  Mythological Replicas [nw_pack],
  Hydroponics [hydroponics],
  Mutant NPCs [mutant_npcs],
  No Rail Stations [No_Rail_Stations],
  Folding Parts pack [deoxymod],
  Vehicle Additions Pack [blazemod],
  Tanks and Other Vehicles [Tanks],
  Roadheader and other mining vehicles [Heavy miners],
  No Fungal Monsters [No_Fungi],
  Beta National Guard Camp [national_guard_camp]
  ]

[ZhilkinSerg]

Do you have a savegame affected by this issue?

[Funguss]

Sure thing, should have done that in the first place, shouldn't I?
Bentonia.zip
Edit: linked to the correct save. D'oh!

[ZhilkinSerg]

Where is that pile in question?

[Funguss]

Character is standing in the middle of them, every pile generates lag, but the more items the worse it is. It seems to be related to the amount of pages there are. Walking east and west between those two central tiles should be noticeably slow, walking east especially. It takes about two seconds for me.

There's a fire ring in the centre of the zoo, too, with filthy armour and clothing nearby. West of that are gigantic pliles of potential laundry. All of these cause lag when walked past, too, especially the western laundry pile. The central tile has 41 pages of items bordering them, according to adanced inventory management.

Edit: It's not about walking through the tile but walking next to them, diagonally and horizontally. Walking through the centre of 9x9 tile sections filled with small, non-stacking items generates the most lag. Walking through them probably generates as much lag as walking beside them but I haven't tested this.

[foulman]

I notice this behavior all the time in my deathmobile storage areas. The more you have the slower it gets, I always chalked it up to something like temperature calculations for individual rags or something.

[Funguss]

This behaviour particularly? I doubt it's temperature calculations, as it seems odd to process those when the PC walks past them. I also think it's related to the amount of item pages, not the amount of individual items. My filthy clothing piles have no stacking items, occupy fewer tiles and have many less items overall than my main loot pile, yet has equivalent pages and lag.

I'm wondering if the advanced inventory is buffering as you move, but this occurs even if 'a'll isn't selected on either column. The inventory lists for each tile may still be getting built, though. The amount of lag on move does seem equivalent to other item commands, so I imagine a list is being built for some reason.

[kevingranade]

My guess is that this is auto pick up kicking in and iterating over all the items in the stack trying to decide whether to pick any of them up.

…

On Thu, Feb 27, 2020, 8:55 AM Funguss ***@***.***> wrote: This behaviour particularly? I doubt it's temperature calculations, as it seems odd to process those when the PC walks past them. I also think it's related to the amount of item pages, not the amount of individual items. My filthy clothing piles have no stacking items, occupy fewer tiles and have many less items overall than my main loot pile, yet has equivalent pages and lag. I'm wondering if the advanced inventory is buffering as you move, but this occurs even if 'a'll isn't selected on either column. The inventory lists for each tile may still be getting built, though. The amount of lag on move does seem equivalent to other item commands, so I imagine a list is being built for some reason. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38340?email_source=notifications&email_token=AAGSA5B4BPHYMCGEGG3D6OTRE7WARA5CNFSM4K3P32B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDAYI#issuecomment-592064609>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSA5GNVSTLE574U22J3I3RE7WARANCNFSM4K3P32BQ> .

[Funguss]

Yes!! Very nicely done! Turned autopickup off and it's no longer an issue. I didn't even realise I had it on, it's bound to "unknown key 7", whatever that is. I must have hit it by accident at some point.

Ok, should I close this then or update it for autopickup? A quick search shows there's no open issue at the moment and it seems it could do with some optimization.

[kevingranade]

Leave it open, it needs optimization.

…

On Thu, Feb 27, 2020, 11:27 AM Funguss ***@***.***> wrote: Yes!! Very nicely done! Turned autopickup off and it's no longer an issue. I didn't even realise I had it on, it's bound to "unknown key 7", whatever that is. I must have hit it by accident at some point. Ok, should I close this then or update it for autopickup? A quick search shows there's no open issue at the moment and it seems it could do with some optimization. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38340?email_source=notifications&email_token=AAGSA5FGCOXU7W5WYS2H5O3RFAH3RA5CNFSM4K3P32B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFULYA#issuecomment-592135648>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSA5BQPNAC7665N7766CDRFAH3RANCNFSM4K3P32BQ> .

[kevingranade]

Can you provide your autopickup configuration? I'm not having any luck getting this to trigger.

[Funguss]

Sure. It was "wheat", disabled, and "*arrow", disabled. So having autopickup on without anything defined, basically.