Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie recipes should require butter. #37471

Closed
I-am-Erk opened this issue Jan 28, 2020 · 14 comments
Closed

Pie recipes should require butter. #37471

I-am-Erk opened this issue Jan 28, 2020 · 14 comments
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.

Comments

@I-am-Erk
Copy link
Member

Describe the bug

Pie recipes currently require flour, water, and filling. That would make a terrible crust.

Steps To Reproduce

Go in game and try to bake a pie.

"components": [
      [ [ "flour", 30 ] ],
      [ [ "sweet_fruit_like", 8, "LIST" ] ],
      [ [ "sugar", 20 ], [ "syrup", 4 ], [ "beet_syrup", 4 ], [ "molasses", 4 ] ],
      [ [ "water", 1 ], [ "water_clean", 1 ] ]
    ]

You won't need butter.

Then go into real life and try to bake a pie.
Enjoy the inedible horror of the butterless crust, you monster.

Expected behavior

The recipe needs a butter or lard component. Oil is not a sufficient substitute.

Additional context

I believe this applies to all pie sub-recipes, but I haven't looked.

@I-am-Erk I-am-Erk added Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Jan 28, 2020
@Alapaga
Copy link

Alapaga commented Jan 28, 2020

I second this, I would consider adding 12/16 units of butter to the recipie of pie, cause that's about half the pack. I also noticed that the butter usage in other recipies is minimal, for exaple cake only requires two units and that is a very small amount. Also, I'm French, so I have that bias going on where I need to put butter in everything.

@killmepete
Copy link

I'd like to try and tackle this game breaker if I can. Looks like a good first issue :)

@KorGgenT
Copy link
Member

requirements would be a good thing to use here too

@Maleclypse
Copy link
Member

Maleclypse commented Jan 29, 2020

Yes, now that butter is no longer a finite resource many recipes should have butter added.

Edit: Any recipes that have butter added will likely need new calorie inputs.

@michaelmeyer26
Copy link

It's entirely possible to make pie crust using oil. Maybe it's not as enjoyable to most people, but completely removing the option seems overly limiting when it's a thing people can and do make.

Maybe a separate recipe with the oil crust is the right call if people are opposed to oil being an option along with butter?

@killmepete
Copy link

killmepete commented Jan 29, 2020 via email

@RarkGrames
Copy link
Contributor

I think that two different recipes is a good idea to have. What if I want to RP as the fifth horseman of the Apocalypse, riding on my pale horse, burning all the cookbooks I come along to force the remainder of humanity to eat pies with butterless crust, dooming them to eternal torment?

Just kidding... I would never do such a horrible thing. (Or would I? Duh-duh-DUUH)

@Ezsk
Copy link

Ezsk commented Jan 29, 2020

How is the calorie at result? maybe terrible than crust.

@I-am-Erk
Copy link
Member Author

Apparently some people do make pie crusts with oil. I am not a fan of supporting this kind of moral iniquity in the game, but if someone is that depraved I guess I can't block the PR

@l29ah
Copy link
Contributor

l29ah commented Jan 30, 2020

I made a pie with sunflower oil just fine IRL.

@I-am-Erk
Copy link
Member Author

I think you know how I feel about people like you.

@Voker57
Copy link
Contributor

Voker57 commented Jan 30, 2020

There should be morale modifier based on ingredients used, similar to what is done with vitamins.

@Eliijahh
Copy link

Can confirm from Italy this supposedly moral iniquity of using oil for pies 🇮🇹

sharkfinsouperman added a commit to sharkfinsouperman/Cataclysm-DDA that referenced this issue Feb 29, 2020
Resolves issue CleverRaven#37471

As my first contribution, I'll attempt to add butter and lard to the following pie recipes:
-Pie
-Veggie pie
-Meat pie
-Maple pie
-Humble pie
@stale
Copy link

stale bot commented Mar 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Mar 1, 2020
@I-am-Erk I-am-Erk closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests