Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bugs while interacting with bucket-type containers (with liquid) on the ground #36597

Closed
Night-Pryanik opened this issue Dec 31, 2019 · 0 comments · Fixed by #36681
Closed

Several bugs while interacting with bucket-type containers (with liquid) on the ground #36597

Night-Pryanik opened this issue Dec 31, 2019 · 0 comments · Fixed by #36681
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@Night-Pryanik
Copy link
Contributor

Describe the bug

I have one stock pot filled with water standing on the ground right next to me
изображение

It is fully filled, 48 charges
изображение

Activating it consumes charges prior to any action taken
изображение

Pressing Esc cancels interaction, but debug message pops up
изображение

Ignoring the message duplicates the stock pot
изображение

Steps To Reproduce

  1. Get a bucket-type container;
  2. Fill it with liquid;
  3. Drop it on the ground;
  4. Activate it;
  5. Cancel the interaction.
  6. Observe errors and duplicating.

Expected behavior

No errors while interacting with bucket-type containers.

Versions and configuration

  • OS: Windows 10 Pro x64
  • Game Version: 0.D-10900
  • Graphics version: Tiles
  • Mods loaded: default only.
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 31, 2019
HoussemFerjaoui added a commit to HoussemFerjaoui/Cataclysm-DDA that referenced this issue Jan 4, 2020
@HoussemFerjaoui
fix bugs related to interacting with bucket-type containers
58be495 
#Summary

SUMMARY: Bugfixes "fix bugs related to interacting with bucket-type containers"

#purpose of change

fixes CleverRaven#36597 and 36680

#describe the solution

add a condition to check that the item being used dosnt have a use_action before directly consuming it.

#Describe alternatives you've considered

None.
This was referenced Jan 4, 2020
Merged
Merged
This was referenced Jan 5, 2020
Closed
Closed
@HoussemFerjaoui HoussemFerjaoui mentioned this issue Jan 7, 2020
Closed
kevingranade added a commit that referenced this issue Jan 12, 2020
@kevingranade
fix bugs related to interacting with bucket-type containers (#36681)
1d7960f 
#Summary

SUMMARY: Bugfixes "fix bugs related to interacting with bucket-type containers"

#purpose of change

fixes #36597 and 36680

#describe the solution

add a condition to check that the item being used dosnt have a use_action before directly consuming it.

#Describe alternatives you've considered

None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bugs related to interacting with bucket-type containers HoussemFerjaoui/Cataclysm-DDA
1 participant
@Night-Pryanik