Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tac Vest's Encumbrance when full is too high #34768

Closed
KurzedMetal opened this issue Oct 15, 2019 · 5 comments
Closed

Tac Vest's Encumbrance when full is too high #34768

KurzedMetal opened this issue Oct 15, 2019 · 5 comments
Labels
Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@KurzedMetal
Copy link
Contributor

Describe the bug

Tac Vest Encumbrance seems prohibitively high.
image

Expected behavior

Not having twice as much encumbrance as a Backback for 1/5 of the capacity.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.D-8494-gc95073d [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Alternative Map Key [alt_map_key],
    Mutant NPCs [mutant_npcs]
    ]
@mrkybe
Copy link
Contributor

mrkybe commented Oct 15, 2019

The description/mechanics are also unclear. As the Tac Vest can store 4 mags, being full could either be interpreted as having all 4 mags stored or using the provided 3L of storage. As a new player, I'd probably assume its talking about the number of mag storage spots used, but is it? Or is it just talking about the 3L of storage.

@kevingranade
Copy link
Member

The variable encumbrance is just based on volume stored, it doesn't look at slots at all.
Similarly, it's not "2x capacity for 5x encumbrance" because that also doesn't incorporate the slot capacity.

I'm not saying you're wrong overall, but the question isn't how it compares to a backpack, but whether it portrays the tactical best correctly. I'm actually really sceptical of it having any significant storage capacity other than the holsters in the first place, if I skim through product listings for this kind of thing, it looks like other than holster storage, they only tend to have map storage, which is less than a quarter liter, not 3 litres.

@tenmillimaster
Copy link
Member

tenmillimaster commented Oct 17, 2019

I think earlier it was based on load bearing vests like ALICE and the like(there's a largeish musette bag in the back).

LBV:

I was picturing it as one of these vests.

They're more common; I figured since it couldn't hold a gun, and like 6 mags, volume would be easier.

Do we have support for multiple item contents?

@Night-Pryanik Night-Pryanik added <Suggestion / Discussion> Talk it out before implementing Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 20, 2019
@stale
Copy link

stale bot commented Nov 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Nov 19, 2019
@stale
Copy link

stale bot commented Dec 19, 2019

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Dec 19, 2019
pjf added a commit to pjf/Cataclysm-DDA that referenced this issue Feb 27, 2020
I lived in fear of using my tac-vest storage, as encumbrance 30 was much
higher than anything else I wear.

This change maxes the encumbrance at 5, using the rule of thumb that
1L storage = 1 encumbrance for well-designed storage. The tac-vest has
a base encumbrance of 2, and 3 litres of storage.

I'm not sure how the max encumbrance was showing as 30, as reading
`item::get_encumber_when_containing` uses 1 encumb per 250ml, so 3L
should only add 12 encumbrance, not 28. ‾\_(ツ)_/‾

Closes CleverRaven#34768
pjf added a commit to pjf/Cataclysm-DDA that referenced this issue Feb 29, 2020
Compared to MBR vests (encumb 7 empty, with 6L + 4x1L magazines), and
makeshift slings from bedsheets (encumb 15 for 10L), the tac vest had
unusually high max encumbrance of 30.

This commit reduces the max encumbrance to 10, making it not as good as
an MBR vest, and on-par with a bedsheet on a litre-by-litre basis.

Closes CleverRaven#34768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

5 participants