Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB guns can foul, despite not using gunpowder #34487

Closed
Relyksboa opened this issue Oct 5, 2019 · 1 comment · Fixed by #34503
Closed

BB guns can foul, despite not using gunpowder #34487

Relyksboa opened this issue Oct 5, 2019 · 1 comment · Fixed by #34503
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics

Comments

@Relyksboa
Copy link
Contributor

Describe the bug

BB guns can foul, despite firing pellets without using gunpowder, smokeless or otherwise

Steps To Reproduce

Steps to reproduce the behavior:

  1. Find or spawn BB gun
  2. fire it a few times
  3. notice it ticking the fouling meter unexpectedly

Expected behavior

For a gun powder-less BB gun to not foul.

Screenshots

If applicable, add screenshots to help explain your problem.
image
as seen here, fouling BB gun

Versions and configuration

  • OS: [e.g. iOS 8 or Windows 10 or Ubuntu 18.04]
  • Game Version: post fouling update
  • Graphics version: [Tiles]
  • Mods loaded: [DDA]

Additional context

n/a
@snipercup
Copy link
Contributor

snipercup commented Oct 5, 2019 •
edited
Loading

Probably by #34240
This will be fixed by adding

"effects": [ "NON-FOULING" ]

to the json of the BB gun. I think

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Oct 5, 2019
@peeley peeley mentioned this issue Oct 6, 2019
Merged
Rivet-the-Zombie added a commit that referenced this issue Oct 7, 2019
@Rivet-the-Zombie
Merge pull request #34503 from peeley/fix_BBgun_fouling
32380dc 
Adds NON-FOULING flag to BB gun, fixing fouling bug in #34487 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds NON-FOULING flag to BB gun, fixing fouling bug in #34487 .
3 participants
@Night-Pryanik @snipercup @Relyksboa