Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charcoal smoker fits more charcoal than its volume #27988

Closed
l29ah opened this issue Jan 30, 2019 · 2 comments
Closed

Charcoal smoker fits more charcoal than its volume #27988

l29ah opened this issue Jan 30, 2019 · 2 comments
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@l29ah
Copy link
Contributor

l29ah commented Jan 30, 2019

Describe the bug
The charcoal smoker is 4.5L and fits 200 charcoal inside that is 5L.
Also, converting wood into charcoal increases its volume it seems, so maybe charcoal unit volume should be lowered?

0.C-37176-g88c8f68af8-dirty
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Jan 31, 2019
jeremyshannon added a commit to jeremyshannon/Cataclysm-DDA that referenced this issue Jan 31, 2019
@jeremyshannon
Charcoal smoker shouldn't hold more charcoal than its own volume
0b229a6 
Fix for CleverRaven#27988
@jeremyshannon jeremyshannon mentioned this issue Jan 31, 2019
Closed
@jeremyshannon
Copy link
Contributor

I checked it out, and 10L of wood produces 5L of charcoal in game, which is about right, Where it was off is that it was like 97% of the weight of the input wood, when it should be about 25% according to wikipedia. The smoker being a Tardis is clearly off.

kevingranade pushed a commit that referenced this issue Feb 1, 2019
@jeremyshannon @kevingranade
Charcoal smoker shouldn't hold more charcoal than its own volume
e6ae67c 
Fix for #27988
Also reduce charcoal weight to 25% that of input wood, as per wikipedia.
kevingranade pushed a commit that referenced this issue Feb 1, 2019
@jeremyshannon @kevingranade
Charcoal smoker shouldn't hold more charcoal than its own volume
58b75cd 
Fix for #27988
Also reduce charcoal weight to 25% that of input wood, as per wikipedia.
kevingranade added a commit that referenced this issue Feb 1, 2019
@kevingranade
Merge branch '0.D-branch'
2d47130 
* 0.D-branch:
  Charcoal smoker shouldn't hold more charcoal than its own volume Fix for #27988 Also reduce charcoal weight to 25% that of input wood, as per wikipedia.
  Worker ants are brown
  set seed to same as other weather
  Updated plastic chunk from cash cards recipe
  Display both primary and secondary recipe skill requirements as uniform 'skill (lvl/req)' Display batch craft time savings in crafting GUI; Update comment describing recipe::required_skills_string
@kevingranade
Copy link
Member

Fixed by #28004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@l29ah @kevingranade @Night-Pryanik @jeremyshannon