It's coming! (0.D coordination issue) (for real) DONE #27843

kevingranade · 2019-01-24T21:59:40Z

It's finally time for 0.D, for real this time.

What does this mean?

We're really for real making a real push toward really releasing the real 0.D.
The realease blockers are tracked in the realease project. Once these are addressed, we can proceed to realease.

What does this change?

We are effectively in Feature Freeze now.
I've established a release branch https://github.com/CleverRaven/Cataclysm-DDA/tree/0.D-branch
Bugfixes should be merged to the new 0.D-branch branch, and (typically) they should also be merged to the master branch.

Going forward, any feature PRs should be merged only to the master branch.
Once we enter Content Freeze, PRs that add new items/monsters/terrain/etc should not be merged to the 0.D-branch
Once we enter String Freeze, PRs should not be merged to 0.D-branch if they edit any strings, even if the strings are slightly wrong.

Can I help?

If you know about any game-breaking bugs that are not listed here, please leave a comment with a link to the issue.

I-am-Erk · 2019-01-24T23:18:23Z

Could we get a tag for PR's like "0.D freeze" so that if PRs are getting skipped due to the current state of the freeze, authors can see why? Otherwise I anticipate a bit of "why has nobody addressed my PR" going on in the next while.

Or am I misunderstanding what the freeze does?

darktoes · 2019-01-24T23:38:37Z

I believe it just means that feature PR's will be added to the master branch but not the 0.D branch. So you can still PR features, but they won't be in 0.D.

So 0.C was Cooper, what's the D stand for?

kevingranade · 2019-01-24T23:46:20Z

Correct, last time around Freeze meant "everything stalls until it's done", this time it's just that non-bugfix PRs go to the master branch.

So 0.C was Cooper, what's the D stand for?

Oh right, I'll fix the checklist...

BrettDong · 2019-01-25T02:37:26Z

Just curious, should contributors submit one bug fix PR to 0.D-branch, or submit two PRs one for 0.D-branch and another one for master branch?

Firestorm01X2 · 2019-01-25T04:12:34Z

#27731

This worries me a bit. It is not gamebreaking, but it is noticable graphical bug. If it is affects alot of players - then it is problem.

It is black lines around tiles thingy. I've posted workaround.

Firestorm01X2 · 2019-01-25T04:16:35Z

Additionally ingame help is outdated and contains misinformation.

And ingame tutorial should be checked. It may be broken now.

kevingranade · 2019-01-25T05:59:39Z

Just curious, should contributors submit one bug fix PR to 0.D-branch, or submit two PRs one for 0.D-branch and another one for master branch?

Seperate PRs would make things easier, but it's not necessary.

Additionally ingame help is outdated and contains misinformation.
And ingame tutorial should be checked. It may be broken now.

If you have something specific to report, open an issue. I'm not inclined to block the release based on out-of date help, so whatever gets fixed before release will have to do, and I'm not planning on touching the tutorial.

a1studmuffin · 2019-01-25T06:04:02Z

Woohoo! You may already be aware of it @kevingranade but I believe the Android build will need 28c87d1 merged from master into the 0.D branch to prevent a crash on startup.

Firestorm01X2 · 2019-01-25T09:45:11Z

I'm not planning on touching the tutorial.

There is Tutorial issue:
#17984

And tutorial redisign issue:
#23395

#17984 (comment)

But I think the most important thing it to make the tutorial at least STABLE.

This indicated that tutorial in really bad shape now.

Maybe it is better to just disable tutorial for 0.D. Having bugged tutorial hurts presentation.

Night-Pryanik · 2019-01-25T11:40:44Z

Pick Release Name

If I get it right, we name our releases after post-apocalyptic writers, right? As a possibility, we could name 0.D after Philip K. Dick.

unmaskedguy676 · 2019-01-25T12:12:02Z

I think relase must call: Cataclysm: Dark Days Are Gone

Firestorm01X2 · 2019-01-25T12:18:24Z

If I get it right, we name our releases after post-apocalyptic writers, right? As a possibility, we could name 0.D after Philip K. Dick.

Cataclysm: DDA 0.D "Dick"? Perfect!

nexusmrsep · 2019-01-25T17:59:55Z

Could we get a tag for PR's like "0.D freeze"

I've added the label to the set.

l29ah · 2019-01-26T01:30:45Z

I'm not sure if #26389 is considered game-breaking, but as for me the crafting mechanics is a big part of the game, and being unable to resume crafting annoys a lot and with zombie hordes enabled basically requires one to hide in a basement or at least a tough vehicle without windows for any serious crafting.

Firestorm01X2 · 2019-01-26T16:14:15Z

I am seeing more reports on this from external source:

#27731

It will defenitely hurt game presentation.

Inglonias · 2019-01-26T16:57:15Z

#27731 can be worked around by setting the default renderer to something besides software mode, or at least you can set it to direct3D on windows. I don't know if that resolves the issue on OSX or Linux, though.

I-am-Erk · 2019-01-26T17:09:18Z

If that's the case then we should at least change the default rendering mode in 0.D, although a better bugfix would be approps

Firestorm01X2 · 2019-01-26T17:46:22Z

There is no bugfix, but there is workaround that worked for me year ago. Game just should be built using older version of MXE.

Firestorm01X2 · 2019-01-27T08:22:38Z

#27731 can be worked around by setting the default renderer to something besides software mode, or at least you can set it to direct3D on windows. I don't know if that resolves the issue on OSX or Linux, though.

#27915

hyper2snyper · 2019-01-28T20:21:05Z

0.D Decklin

Epictyphlosion · 2019-01-29T19:57:04Z

This is really great news! However, this does mean that I'll have to expedite my restyling of the vehicle code, as I want some of the last few 0.C experimental releases to have the new style of code

~~If anyone tries to beat me to it, I swear to God...~~

Chambs-15 · 2019-01-31T03:17:45Z

0.D Decklin

We all know it's going to be Dick...

Leland · 2019-01-31T03:47:17Z

Awesome. I have a couple things I'll try to get finished for this.

kevingranade · 2019-02-25T00:04:27Z

In order to get better testing, I'm going to copy the current master branch to a branch named development, and replace the current master with a copy of the 0.D-branch.
This means that until the release is completed, the Jenkins and travis builds will be exercising 0.D code, and the released versions will also be pure 0.D.

Going forward, we should only merge 0.D changes to master, and any future changes should go to the development branch.

After the release, development will be merged back onto master and continue as usual.

a1studmuffin · 2019-02-25T09:20:11Z

As I posted in the Reddit thread, I just tried Android build 8544 and am seeing SDL viewport rendering scale issues with both the hardware and software renderer that makes the game unplayable. The main menu draws at the correct size at first, but draws updates (eg. cycling menu items on the main menu) much smaller in the top left corner. Did someone change some SDL renderer logic for the 0.D release? This is new behaviour in Android build 8544 (0.C-37525-g2a51b1b). Build 8539 (0.C-37569-gbf99f81) and earlier work fine, though I assume based on those version numbers that the 0.D/master branch switchover Kevin mentioned has happened between these two build machine versions.

ifreund · 2019-02-25T10:36:38Z

@a1studmuffin yeah, I probably messed that up with #28253. I don't think I have any way of testing on android unfortunately, but will see if I can figure out a fix from just reading the code

aawilson · 2019-02-25T16:15:42Z

https://en.wikipedia.org/wiki/List_of_zombie_films (with director names!)

aawilson · 2019-02-25T16:20:33Z

For authors, Denning wrote the original "Dark Sun" stuff. Dunsany wrote "The King of Elfland's Daughter" and is considered the progenitor of modern SF and Fantasy. There's also Doyle, as in Sir Arthur Conan Doyle.

a1studmuffin · 2019-02-26T00:35:49Z

@ifreund No worries, feel free to ping me if you've got a candidate fix - I will test Android to verify before you make the PR.

BrettDong · 2019-02-26T09:27:48Z

Translation progress as of Feb 28:

language	progress / %
Chinese (Simplified)	100
Russian	100
Japanese	100
German	100
Polish	99.88
Spanish (Argentina)	97.87
Chinese (Traditional)	81.12
Spanish (Spain)	80.87
Korean	64.23
Hungarian	60.49
French	41.16

Epictyphlosion · 2019-02-26T20:43:06Z

@BrettDong Japanese and Chinese is ahead of French and German?
Nani?!

In all seriousness, I could try putting some placeholder translations in for some languages. And by placeholder, I mean using online translators (not specifically Google Translate). It definitely won't be perfect, especially for languages like Traditional Chinese and Korean, but it might be at least somewhat understandable to those that play with one of the placeholder translations. Plus, if people spot errors within the placeholders, they can let us know.

Once the actual translations have been completed, they will replace the placeholders ASAP.

This is probably a really dumb idea, but hey, it's a start.

Wuzzy2 · 2019-02-27T06:13:56Z

In all seriousness, I could try putting some placeholder translations in for some languages. And by placeholder, I mean using online translators (not specifically Google Translate).

spits coffee on screen
head smashes on table
Nooooooooooooooooooooooooo …
Never ever do this shit, please. All auto-translators suck, it would just create a huge mess.
German will be finished soon enough, just be patient. Jeez.

pingpong2011 · 2019-03-01T01:24:03Z

Is it going to work period and look correct?

Nobody had commented on my discourse thread or the github issue with clear examples and reproduction steps:
#24844

I try out the "stable" revision, have to close/re-open, and it keeps resizing the window and distorting fonts. I just tried out 0.C-37549-gfaafa3a (8551) and that issues gone, but font rendering is still a little bit off from .C-stable. It doesn't help the "patch" mentioned in my issue above STILL hasn't been addressed, and it would probably take is removing the equals or adding a +1 to the width and height comparisons (line 1955 in the diff) to make font sizes work. If I choose size 18 font I want size 18 font damnit, not get 18 by doing 19, 19, 18 (width, height, size) that still has some errors (single line of pixels missing on one side or the other, distorted letters). An ASCII game that incorrectly renders ASCII. I don't get it.

kevingranade · 2019-03-01T08:34:56Z

Sorry I haven't acknowledged your issue, I will be looking into the font rendering problem very soon, it's the next problem I plan to investigate.

RickySandbox · 2019-03-01T17:48:25Z

I try out the "stable" revision, have to close/re-open, and it keeps resizing the window and distorting fonts. I just tried out 0.C-37549-gfaafa3a (8551) and that issues gone, but font rendering is still a little bit off from .C-stable. It doesn't help the "patch" mentioned in my issue above STILL hasn't been addressed, and it would probably take is removing the equals or adding a +1 to the width and height comparisons (line 1955 in the diff) to make font sizes work. If I choose size 18 font I want size 18 font damnit, not get 18 by doing 19, 19, 18 (width, height, size) that still has some errors (single line of pixels missing on one side or the other, distorted letters). An ASCII game that incorrectly renders ASCII. I don't get it.

A font at 18pt isn't 18 pixels high. I've played with Bitstream Vera Mono at 18pt. I downloaded VeraMono.ttf into my Cataclysm-DDA/data/font directory, then I loaded up Cataclysm-DDA/config/fonts.json in my text editor and changed it like this:

{
"fontblending": false,
"fontwidth": 11,
"fontheight": 22,
"fontsize": 18,
"typeface": "VeraMono",
"map_fontwidth": 22,
"map_fontheight": 22,
"map_fontsize": 18,
"map_typeface": "VeraMono",
"overmap_fontwidth": 22,
"overmap_fontheight": 22,
"overmap_fontsize": 18,
"overmap_typeface": "VeraMono"
}

I played with square tiles on the map & overmap, as my settings reflect, but you could easily change the width to 11 if you wanted a non-square display.

The problem, if anyone is interested, is related to font hinting and has been debated for years. In fact, Macs ignore font hinting by default, whereas Windows does not. If you'd like to know more, then you could start here: https://www.typotheque.com/articles/hinting

pingpong2011 · 2019-03-01T17:52:34Z

Thank you kevin, I apologize for being a little toxic about it.

Ricky, you made the post as I was making mine! Since you seem knowledgeable, could there be a way to convert a font to a different kind, for separate scaling options / more 1:1 expectations? I'd gladly raster/bake my own font if it wasn't too difficult.

Epictyphlosion · 2019-03-01T20:10:21Z

Never ever do this shit, please. All auto-translators suck, it would just create a huge mess.
German will be finished soon enough, just be patient. Jeez.

I didn't think that'd be well received, lol
I should probably just learn C++ or something. That way I can make myself useful instead of just reformatting code and simple things like that

Wuzzy2 · 2019-03-01T23:52:02Z

May I direct the attention to #23484?

kevingranade · 2019-03-03T19:18:14Z

Build 8561 is a pretty serious candidate.

ghost · 2019-03-04T02:07:00Z

Tazeell on the discourse reports an issue with the vehicle water faucet: https://discourse.cataclysmdda.org/t/vehicle-water-faucet/19053

Night-Pryanik · 2019-03-04T07:06:00Z

Tazeell on the discourse reports an issue with the vehicle water faucet: https://discourse.cataclysmdda.org/t/vehicle-water-faucet/19053

Making faucets compatible with any liquid in the tank is an enhancement and not a release blocker.

Inglonias · 2019-03-05T12:56:42Z

are we done yet?

Leland · 2019-03-10T23:45:11Z

Congrats all!

kevingranade added the Organization General development organization issues label Jan 24, 2019

kevingranade added this to the 0.D milestone Jan 24, 2019

kevingranade self-assigned this Jan 24, 2019

nexusmrsep pinned this issue Jan 25, 2019

CleverRaven deleted a comment from Zombiemanpig Feb 24, 2019

ifreund mentioned this issue Feb 25, 2019

Corrects some out-of-date documentation in JSON_INFO.md #28360

Merged

ifreund mentioned this issue Feb 26, 2019

The option to change skin tone, hair color and hairstyle is missing. #28389

Closed

kevingranade changed the title ~~It's coming! (0.D coordination issue) (for real)~~ It's coming! (0.D coordination issue) (for real) DONE Mar 8, 2019

kevingranade closed this as completed Mar 8, 2019

OzoneH3 unpinned this issue Mar 8, 2019

OzoneH3 pinned this issue Mar 8, 2019

Night-Pryanik unpinned this issue Mar 8, 2019

ZhilkinSerg mentioned this issue Apr 5, 2020

Translation without Transifex #39164

Open

It's coming! (0.D coordination issue) (for real) DONE #27843

It's coming! (0.D coordination issue) (for real) DONE #27843

Comments

kevingranade commented Jan 24, 2019 • edited Loading

What does this mean?

What does this change?

Can I help?

I-am-Erk commented Jan 24, 2019 • edited Loading

darktoes commented Jan 24, 2019

kevingranade commented Jan 24, 2019

BrettDong commented Jan 25, 2019

Firestorm01X2 commented Jan 25, 2019 • edited Loading

Firestorm01X2 commented Jan 25, 2019 • edited Loading

kevingranade commented Jan 25, 2019

a1studmuffin commented Jan 25, 2019

Firestorm01X2 commented Jan 25, 2019 • edited Loading

Night-Pryanik commented Jan 25, 2019

unmaskedguy676 commented Jan 25, 2019 • edited Loading

Firestorm01X2 commented Jan 25, 2019 • edited Loading

nexusmrsep commented Jan 25, 2019

l29ah commented Jan 26, 2019

Firestorm01X2 commented Jan 26, 2019

Inglonias commented Jan 26, 2019

I-am-Erk commented Jan 26, 2019

Firestorm01X2 commented Jan 26, 2019

Firestorm01X2 commented Jan 27, 2019 • edited Loading

hyper2snyper commented Jan 28, 2019

Epictyphlosion commented Jan 29, 2019 • edited Loading

Chambs-15 commented Jan 31, 2019

Leland commented Jan 31, 2019

kevingranade commented Feb 25, 2019

a1studmuffin commented Feb 25, 2019

ifreund commented Feb 25, 2019

aawilson commented Feb 25, 2019 • edited Loading

aawilson commented Feb 25, 2019

a1studmuffin commented Feb 26, 2019

BrettDong commented Feb 26, 2019 • edited Loading

Epictyphlosion commented Feb 26, 2019 • edited Loading

Wuzzy2 commented Feb 27, 2019

pingpong2011 commented Mar 1, 2019

kevingranade commented Mar 1, 2019 via email

RickySandbox commented Mar 1, 2019 • edited Loading

pingpong2011 commented Mar 1, 2019

Epictyphlosion commented Mar 1, 2019

Wuzzy2 commented Mar 1, 2019

kevingranade commented Mar 3, 2019

ghost commented Mar 4, 2019

Night-Pryanik commented Mar 4, 2019

Inglonias commented Mar 5, 2019

Leland commented Mar 10, 2019

kevingranade commented Jan 24, 2019 •

edited

Loading

I-am-Erk commented Jan 24, 2019 •

edited

Loading

Firestorm01X2 commented Jan 25, 2019 •

edited

Loading

Firestorm01X2 commented Jan 25, 2019 •

edited

Loading

Firestorm01X2 commented Jan 25, 2019 •

edited

Loading

unmaskedguy676 commented Jan 25, 2019 •

edited

Loading

Firestorm01X2 commented Jan 25, 2019 •

edited

Loading

Firestorm01X2 commented Jan 27, 2019 •

edited

Loading

Epictyphlosion commented Jan 29, 2019 •

edited

Loading

aawilson commented Feb 25, 2019 •

edited

Loading

BrettDong commented Feb 26, 2019 •

edited

Loading

Epictyphlosion commented Feb 26, 2019 •

edited

Loading

RickySandbox commented Mar 1, 2019 •

edited

Loading