Trivial: minor speedup of monster->Character attitude calculation (#4…

…5421)

* speedup monster::attitude( const Character *u )

Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>

src/monster.cpp

@@ -1132,19 +1132,20 @@ monster_attitude monster::attitude( const Character *u ) const
         }
 
         for( const trait_id &mut : u->get_mutations() ) {
-            for( const std::pair<const species_id, int> &elem : mut.obj().anger_relations ) {
-                if( type->in_species( elem.first ) ) {
-                    effective_anger += elem.second;
-                }
+            const mutation_branch &branch = *mut;
+            if( branch.ignored_by.empty() && branch.anger_relations.empty() ) {
+                continue;
             }
-        }
-
-        for( const trait_id &mut : u->get_mutations() ) {
-            for( const species_id &spe : mut.obj().ignored_by ) {
+            for( const species_id &spe : branch.ignored_by ) {
                 if( type->in_species( spe ) ) {
                     return MATT_IGNORE;
                 }
             }
+            for( const std::pair<const species_id, int> &elem : branch.anger_relations ) {
+                if( type->in_species( elem.first ) ) {
+                    effective_anger += elem.second;
+                }
+            }
         }
     }