boot-qemu.sh: Hoist '-nodefaults' from ppc64le arguments to main arguments #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments This prevents QEMU from creating devices underneath us, which can change across QEMU versions (see de875be). To prevent this in the future, add '-nodefaults' for all invocations of QEMU, not just powerpc64le. Tested with QEMU 3.1.0, 4.2.0, and 5.0.0-rc2. NOTE: This is the only architecture that we actually set devices for so this should be a no-op for everything else but we might add other devices in the future. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents QEMU from creating devices underneath us, which can change
across QEMU versions (see de875be). To prevent this in the future,
add '-nodefaults' for all invocations of QEMU, not just powerpc64le.
Tested with QEMU 3.1.0, 4.2.0, and 5.0.0-rc2.
NOTE: This is the only architecture that we actually set devices for so
this should be a no-op for everything else but we might add other
devices in the future.