Skip to content

Commit

Permalink
boot-qemu.sh: Add '-nodefaults' to ppc64le command line
Browse files Browse the repository at this point in the history
An upcoming QEMU change will make it so that the bmc devices are created
automatically. Unfortunately, that breaks our command line with the
following cryptic error:

  qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS

The author of the patch changed it so that the devices are only created
when '-nodefaults' is not set (i.e. using defaults). Add this flag to
our QEMU command line so that this command line continues to work for
all QEMU versions. Tested locally with 3.1.0 (the version in Debian
stable), 4.2.0 (current QEMU stable), and 5.0.0-rc1 (latest QEMU -rc).

Link: https://lore.kernel.org/qemu-devel/20200404071707.GA24708@ubuntu-m2-xlarge-x86/
Link: https://lore.kernel.org/qemu-devel/20200404153655.166834-1-clg@kaod.org/
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
  • Loading branch information
nathanchance committed Apr 7, 2020
1 parent 5d9d3f6 commit de875be
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion boot-qemu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ function setup_qemu_args() {
-device "ipmi-bmc-sim,id=bmc0"
-device "isa-ipmi-bt,bmc=bmc0,irq=10"
-L "${IMAGES_DIR}/" -bios skiboot.lid
-machine powernv )
-machine powernv
-nodefaults )
QEMU_RAM=2G
QEMU=( qemu-system-ppc64 ) ;;

Expand Down

0 comments on commit de875be

Please sign in to comment.