Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update codebase to reflect the latest configuration in the parent open-sdg and open-sdg-site project #26

Merged
merged 11 commits into from
Jun 6, 2024

Conversation

jaylenw
Copy link
Member

@jaylenw jaylenw commented Mar 12, 2024

What does this PR do?

Background info

  • GitHub Actions workflows are failing as seen here https://github.com/CityOfLosAngeles/open-sdg-site-starter/actions/runs/8253771317 due do the build process accessing the outdated version of the data site. The workflows should be able to complete successfully after the latest data build configuration has been deployed and changes are made to the site that resolves the errors from running the HTML validation scripts.

  • @kerrylacity @naomiikd I think you two should create a GitHub Issue to resolve the errors below that occurs when ./scripts/test/html_proofer_staging.sh and ./scripts/test/html_proofer_prod.sh are ran once this PR has been merged.

vscode ➜ /workspaces/open-sdg-site-starter (ghi-25) $ ./scripts/test/html_proofer_staging.sh 
Running ["ScriptCheck", "LinkCheck", "ImageCheck"] on ["./_test"] on *.html... 


Ran on 561 files!


- ./_test/index.html
  *  internally linking to ../goals, which does not exist (line 257)
     <a href="../goals">goal</a>

HTML-Proofer found 1 failure!
vscode ➜ /workspaces/open-sdg-site-starter (ghi-25) $ ./scripts/test/html_proofer_prod.sh 
Running ["ScriptCheck", "LinkCheck", "ImageCheck"] on ["./_site"] on *.html... 


Ran on 561 files!


- ./_site/index.html
  *  internally linking to ../goals, which does not exist (line 257)
     <a href="../goals">goal</a>

HTML-Proofer found 1 failure!
vscode ➜ /workspaces/open-sdg-site-starter (ghi-25) $ 

SDG Data Portal accessible via localhost:9000 after following the README.md's instructions

sdg-data-site-local

Running Jekyll Server to serve built site locally

sdg-dev-local

sdg-site-loads-locally

*Note that not all of the data will load on the site as there is a CORS issue present. This should not exist with configuration in the cloud environment.
site-data-not-loading-cors

How can this be tested (manually and/or automated test)?

Provide manual tests steps if applicable

The README.md mentions accessing the site locally in the browser by running the jekyll serve command. Refer to the instructions to be able to manually browse the site.

Provide steps for running automated tests if applicable

Please refer to the documentation in the README.md for testing locally.

Which issue(s) is/are related to this PR?

This PR is/are related to issue(s) #25

close #25

@jaylenw jaylenw self-assigned this Mar 12, 2024
@jaylenw
Copy link
Member Author

jaylenw commented Mar 12, 2024

@naomiikd @kerrylacity , as part of the review process please verify the steps for running the site locally works for you.

kerrylacity
kerrylacity previously approved these changes Mar 12, 2024
RV-LACity
RV-LACity previously approved these changes Mar 12, 2024
@jaylenw jaylenw dismissed stale reviews from RV-LACity and kerrylacity via e6a99d6 March 12, 2024 23:24
@jaylenw jaylenw requested a review from RV-LACity March 12, 2024 23:25
@jaylenw jaylenw merged commit f716cfe into development Jun 6, 2024
5 of 6 checks passed
@ita-devops-release-manager ita-devops-release-manager bot added the staged PRs that have been merged into the development branch containing changes yet to be pushed to prod label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staged PRs that have been merged into the development branch containing changes yet to be pushed to prod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codebase to align w/ latest configuration of the parent project
3 participants