-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update codebase to reflect the latest configuration in the parent open-sdg and open-sdg-site project #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@naomiikd @kerrylacity , as part of the review process please verify the steps for running the site locally works for you. |
kerrylacity
previously approved these changes
Mar 12, 2024
RV-LACity
previously approved these changes
Mar 12, 2024
kerrylacity
approved these changes
Jun 6, 2024
RV-LACity
approved these changes
Jun 6, 2024
ita-devops-release-manager
bot
added
the
staged
PRs that have been merged into the development branch containing changes yet to be pushed to prod
label
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
staged
PRs that have been merged into the development branch containing changes yet to be pushed to prod
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Background info
GitHub Actions workflows are failing as seen here https://github.com/CityOfLosAngeles/open-sdg-site-starter/actions/runs/8253771317 due do the build process accessing the outdated version of the data site. The workflows should be able to complete successfully after the latest data build configuration has been deployed and changes are made to the site that resolves the errors from running the HTML validation scripts.
@kerrylacity @naomiikd I think you two should create a GitHub Issue to resolve the errors below that occurs when
./scripts/test/html_proofer_staging.sh
and./scripts/test/html_proofer_prod.sh
are ran once this PR has been merged._layouts
directory has been updated by referring to https://github.com/open-sdg/open-sdg/tree/2.4.0-dev/_layouts. The changes were updated to have the build process complete successfully.SDG Data Portal accessible via
localhost:9000
after following the README.md's instructionsRunning Jekyll Server to serve built site locally
*Note that not all of the data will load on the site as there is a CORS issue present. This should not exist with configuration in the cloud environment.
How can this be tested (manually and/or automated test)?
Provide manual tests steps if applicable
The README.md mentions accessing the site locally in the browser by running the jekyll serve command. Refer to the instructions to be able to manually browse the site.
Provide steps for running automated tests if applicable
Please refer to the documentation in the README.md for testing locally.
Which issue(s) is/are related to this PR?
This PR is/are related to issue(s) #25
close #25