Migrate to Vite (copy from #493) #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Note that the review environment will fail until the pipeline is configured to use env-variables prefixed with
|
TestCafe result is failed for https://kukkuu-local.api.dev.hel.ninja 😿💢💥💥 |
Merged
nikomakela
force-pushed
the
KK-1017-vite
branch
from
60669a4 to
c95bfc8
Compare
TestCafe result is failed for https://kukkuu-local.api.dev.hel.ninja 😿💢💥💥 |
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
1 similar comment
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1017-vite
branch
from
603f377 to
72b0fd5
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
KK-1017. The Create React App (CRA) is deprecated. It is advised to replace the CRA for example with Vite. For example the latest version of the Helsinki Design System (HDS) does not work properly with the CRA. The migration process is done by following the instructions from https://www.robinwieruch.de/vite-create-react-app/: - The index.html is moved from the `/public` to the root. The relative paths are migrated. - Vitest is installed and the configuration for testing-library is made The Sass styles from HDS and the app itself needed a couple of aliases. The new setup includes - Vite instead of CRA - Vitest with the Testing-library instead of Jest - Typescript for Vite
KK-1017
KK-1017. For some reason, the moment in event utils works differently in Vite than what it worked in CRA. However, the same method seems to work when manually tested on a running env.
KK-1017 KK-1040. The CI has been collecting the test coverage.
nikomakela
force-pushed
the
KK-1017-vite
branch
from
72b0fd5 to
2e7ffe6
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
1 similar comment
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1017-vite
branch
from
6fec443 to
c81002e
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1017-vite
branch
from
c81002e to
c080446
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr496.dev.hel.ninja 🚀🚀🚀 |
KK-1040. For some reason the CI needs all the dev dependencies as a prod deps.
TestCafe result is success for https://kukkuu-ui-pr496.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1017-vite
branch
from
c080446 to
ad366c5
Compare
|
The Sonarcloud may need some configuration or new packages still
|
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1017-vite
branch
from
ad366c5 to
1019a5e
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
1 similar comment
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1017-vite
branch
from
061eb67 to
4936ab0
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
|
SonarCloud Quality Gate failed.
|
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr496.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-ui-pr496.dev.hel.ninja 😆🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KK-1040 KK-1017
The #493 was merged too early and it was rolledback. The reason for this was that the Vite needs a new set of environment variables that are prefixed with "VITE_" (#493 (comment)). This PR is just a recreation of that earlier PR that was accidentally merged, because in Github, the PRs cannot be unmerged.
Bases to the huge pile of upgrading and migration changes in #492.
The Create React App (CRA) is deprecated. It is advised to replace the CRA with Vite.
The migration process is done by following the instructions from
https://www.robinwieruch.de/vite-create-react-app/:
/publicto the root. The relative paths are migrated.The Sass styles from HDS and the app itself needed a couple of aliases.
The new setup includes
More about this: