Migrate to Vite #493
Merged
Migrate to Vite #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomakela
force-pushed
the
KK-1017-vite
branch
2 times, most recently
from
ac04c6c to
cbdac77
Compare
nikomakela
force-pushed
the
KK-1017-upgrade-deps
branch
2 times, most recently
from
31c7243 to
d66a020
Compare
nikomakela
force-pushed
the
KK-1017-vite
branch
from
cbdac77 to
34d25fe
Compare
nikomakela
force-pushed
the
KK-1017-upgrade-deps
branch
2 times, most recently
from
b84cdef to
17ebfdd
Compare
nikomakela
force-pushed
the
KK-1017-vite
branch
3 times, most recently
from
b7bb094 to
c043d7f
Compare
nikomakela
force-pushed
the
KK-1017-upgrade-deps
branch
from
f6a3ff4 to
9b40daf
Compare
nikomakela
force-pushed
the
KK-1017-vite
branch
from
c043d7f to
ed78c27
Compare
nikomakela
force-pushed
the
KK-1017-upgrade-deps
branch
from
ce184c3 to
7aeacb9
Compare
nikomakela
force-pushed
the
KK-1017-vite
branch
from
ed78c27 to
33a006e
Compare
nikomakela
force-pushed
the
KK-1017-upgrade-deps
branch
from
85df974 to
3afc3dd
Compare
KK-1017. The Create React App (CRA) is deprecated. It is advised to replace the CRA for example with Vite. For example the latest version of the Helsinki Design System (HDS) does not work properly with the CRA. The migration process is done by following the instructions from https://www.robinwieruch.de/vite-create-react-app/: - The index.html is moved from the `/public` to the root. The relative paths are migrated. - Vitest is installed and the configuration for testing-library is made The Sass styles from HDS and the app itself needed a couple of aliases. The new setup includes - Vite instead of CRA - Vitest with the Testing-library instead of Jest - Typescript for Vite
KK-1017
KK-1017. For some reason, the moment in event utils works differently in Vite than what it worked in CRA. However, the same method seems to work when manually tested on a running env.
nikomakela
force-pushed
the
KK-1017-vite
branch
from
33a006e to
799a57f
Compare
|
Actually, right after merging this to #492 , I realized that the pipeline is not ready for Vite's environment variables, so I reverted branch deletion. Unfortunately this PR is still shown as merged and I cannot remerge it, but the plan was to first take the #492 through the pipeline and then configure the pipeline to use vite-configs. |
This was referenced Oct 20, 2023
|
This PR is recreated here: #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bases to the huge pile of upgrading and migration changes in #492.
The Create React App (CRA) is deprecated. It is advised to replace the CRA with Vite.
The migration process is done by following the instructions from
https://www.robinwieruch.de/vite-create-react-app/:
/publicto the root. The relative paths are migrated.The Sass styles from HDS and the app itself needed a couple of aliases.
The new setup includes
More about this: