Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10765 #1111

Merged
merged 5 commits into from
Nov 18, 2024
Merged

UHF-10765 #1111

merged 5 commits into from
Nov 18, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Nov 14, 2024

UHF-10765

What was done

  • Added missing component wrappers around tfa-entry form, connected accounts form and user profile page.
  • Added help-texts for the user profile page.

How to install

  • Make sure your instance is up and running on latest dev branch. This should be tested with an instance that has TFA on like for example Kaupunkitieto. Notice that there is also a feature branch for Kaupunkitieto in this group of PRs so you can get these both checked at the same time if you you that instance.
    • git pull origin dev or if Kaupunkitieto: git fetch && git checkout UHF-10765
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10765
  • Run make drush-cr

How to test

  • Log in as uid 1 and create a new user with for example editor role.
  • Make sure you have the TFA setup on your local instance. Basically you need to generate the TFA-key and add it to the local.settings.php but you can find more detailed instructions here.
  • Now with a incognito window on browser go and login to the site with the user you created, complete the TFA process and make sure you are able to go through it without having any of the forms being attached to the edges of the browser window.
  • Once logged in the profile page (/user) should be able to see instructions linking to content producer's guide above the "Member for" text.
  • Make sure the text works for all three languages.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@teroelonen teroelonen marked this pull request as ready for review November 15, 2024 12:14
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1111/html_report/

@juho-lehmonen juho-lehmonen self-requested a review November 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants