Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: non-conflicting dependency updates #1016

Merged
merged 15 commits into from
Nov 14, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

No description provided.

vassbo and others added 15 commits November 12, 2024 16:21
- Fixed animation easing not working
- Fixed animation background zoom transform
- Fixed locked show also locking templates
- Fixed color input position
…chApps#1015)

- Add `timeoutMs` constant for consistent timeout handling across tests
- Standardize delay formatting with underscores for readability
- Skip onboarding flow to run current tests without changes
- Adjust locators and remove redundant delays to improve test stability
- Add multiple wait actions
- Fixed default show freezing
- Animations not resetting when transitioning
- Fixed content stuck sometimes with slide clear action
- Fixed slide progress freeze when slide group had no name
- Fixed issues with text edit when first slide was empty
- Fixed overlay/template editor tools loosing focused items if changing slide
- Fixed dropdown scrolling parent
- Multiple scripture references added to each textbox when combined
@vassbo
Copy link
Collaborator

vassbo commented Nov 13, 2024

I don't think we need package-lock in the source, also have you tested e.g. the Google Drive sync?

@DAcodedBEAT
Copy link
Contributor Author

@vassbo package-lock.json is important, especially in projects with contributors, since it ensures everyone is fetching the same dependencies. Here is a great explanation as to why package-lock should exist: https://blog.logrocket.com/why-you-should-use-package-lock-json/

As for testing all of the flows, I figured this would be fine since typescript passes, meaning none of the function signatures have changed.

@vassbo
Copy link
Collaborator

vassbo commented Nov 13, 2024

I see.. Probably fine!

@jzongker What do you think? Is there a reason you removed the package-lock?
https://github.com/ChurchApps/FreeShow/pull/291/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R9

@vassbo vassbo mentioned this pull request Nov 14, 2024
@vassbo vassbo deleted the branch ChurchApps:dev November 14, 2024 12:10
@vassbo vassbo closed this Nov 14, 2024
@vassbo vassbo reopened this Nov 14, 2024
@jzongker
Copy link
Contributor

Adding it back is probably the right call. I've typically excluded it to allow the packages to be updated with bug fixes and non-breaking changes, but the risks of the production builds being slightly different code than development likely outweighs the benefits.

@vassbo vassbo merged commit 5cdc75d into ChurchApps:dev Nov 14, 2024
@vassbo
Copy link
Collaborator

vassbo commented Nov 14, 2024

Sqlite3 must stay at 5.1.6:

But the rest looks to be working as it should!

@DAcodedBEAT
Copy link
Contributor Author

Sqlite3 must stay at 5.1.6:

But the rest looks to be working as it should!

@vassbo Did you experience that locally? I was able to run the playwright test, which made me think this should work.

@vassbo
Copy link
Collaborator

vassbo commented Nov 15, 2024

Yes, locally on Windows, and GitHub actions (macOS/Linux), and another user reported issues on Linux with that version!
(https://github.com/ChurchApps/FreeShow/actions/runs/7586090064)

The Playwright does not compile an electron build, it just runs browser tests.

vassbo added a commit that referenced this pull request Nov 21, 2024
* chore: non-conflicting dependency updates (#1016)

* use package-lock to ensure devs are using the same versions of dependencies

* update sqlite

* update genius-lyrics

* update @googleapis/drive

* add prettier in dev deps so the config is actually used

* update @rollup/plugin-commonjs

* update @rollup/plugin-typescript

* update rollup

* 📄 Reverted sqlite3 version

* 🎤 Fixed microphone input doubled
- Gain control integrated into volume fader
- Fixed auto size on Jesus red words
- Fixed scripture reference doubled in some cases

* ✨ Set tags for multiple shows at once
- Fixed translation issue
- Translation resets to default textbox on remove

* ✔ Fixed project folder right click add not working in empty area
- Fixed custom verse reference align style
- Fixed align style preview incorrect sometimes
- Added toggle variable action to list
- Fixed freeze when applying REST action to slide

* Update snapcraft.yaml (#1031)

* Update snapcraft.yaml

* More cleanup, switch to core24, enable wayland support

* ✨ Set variable value from action
- Optimized transition delay when set to none

* ✨ Overlay preview
- Overlays can be added to the project
- Project templates

* 📱 Remote Enhancements (#1042)

* 📱 Remote updates

* 🖼 Play media from remote
- Slide overlay in edit preview

* ✏ Edit text in remote
- Change show layout from the remote
- Remote clear layers
- Text edit style is preserved
- Text edit textbox number added as group

* ✨ Rearrange groups from remote
- Remote UI updates
- Remote loading
- Controller clear slide

* 📖 Play local scriptures from remote

* 📄 Updated version

---------

Co-authored-by: Arun Philip <dacodedbeat@gmail.com>
Co-authored-by: Erich Eickmeyer <erich@ericheickmeyer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants