Change snap creation method #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vassbo
added a commit
that referenced
this pull request
Nov 14, 2024
* ✔ Fixed stage zoom showing up in output - Fixed animation easing not working - Fixed animation background zoom transform - Fixed locked show also locking templates - Fixed color input position * Change snap creation method (#1014) * fix(tests): adjust timeouts and flow to ensure test reliability (#1015) - Add `timeoutMs` constant for consistent timeout handling across tests - Standardize delay formatting with underscores for readability - Skip onboarding flow to run current tests without changes - Adjust locators and remove redundant delays to improve test stability * ✔ Fixed show loading unused backgrounds - Add multiple wait actions - Fixed default show freezing - Animations not resetting when transitioning - Fixed content stuck sometimes with slide clear action - Fixed slide progress freeze when slide group had no name - Fixed issues with text edit when first slide was empty - Fixed overlay/template editor tools loosing focused items if changing slide - Fixed dropdown scrolling parent - Multiple scripture references added to each textbox when combined * 📄 Fixed package formatting * ✔ Fixed Bible search not working sometimes * ✨ Trigger action on section navigation - Category action - Fixed new show not working when the selected category is deleted - Drop timer in show to quickly create slide - Version update --------- Co-authored-by: Erich Eickmeyer <erich@ericheickmeyer.com> Co-authored-by: Arun Philip <dacodedbeat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow better flexibility when it comes to updating the snap to be whatever we need it to be. I simply took whatever electron-build was outputting and made it customizable. This includes the shell scripts that electron-builder would make to allow it to run properly within a snap.
Fixes for the MIDI interface are still pending, but this is a start.