Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2-7711: cache markdown images #852

Merged
merged 4 commits into from
Aug 29, 2024
Merged

M2-7711: cache markdown images #852

merged 4 commits into from
Aug 29, 2024

Conversation

BamMironov
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-7711

Changes include:

  • A function that collects image URLs in an activity's markdown
  • Caching of the aforementioned images during the Pull-to-Refresh action.
  • Migration for the older versions that prefetches markdown images when the app is open.

@felipeMetaLab
Copy link
Contributor

the code and structure is very good in general. good job :).

felipeMetaLab
felipeMetaLab approved these changes Aug 29, 2024
View reviewed changes
src/shared/lib/services/collectImageUrls.ts Outdated Show resolved Hide resolved
src/shared/lib/services/collectImageUrls.test.ts Outdated Show resolved Hide resolved
@BamMironov BamMironov merged commit ae18545 into release/2.2.2 Aug 29, 2024
4 checks passed
@BamMironov BamMironov deleted the feat/M2-7711_cache-markdown-images branch August 29, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaconC ChaconC ChaconC approved these changes

@felipeMetaLab felipeMetaLab felipeMetaLab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BamMironov @felipeMetaLab @ChaconC