M2-7137: autocompletion: delivery part # 3 #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BamMironov
suggested changes
Jul 18, 2024
| }; | ||
|
|
||
| return ( | ||
| <Box w={size} h={size} transform={'rotate(90deg)'}> |
There was a problem hiding this comment.
Is there a reason we want to rotate it?
There was a problem hiding this comment.
Yes, we've design. Progress started from bottom point. TBD with Inna, jsut in case.
BamMironov
reviewed
Jul 22, 2024
| const { start, stop } = useInterval(onIntervalPass, Interval); | ||
| const { start, stop } = useInterval( | ||
| () => { | ||
| Logger.log('[useDelayedInterval:useInterval] Tick'); |
There was a problem hiding this comment.
I am pretty sure it will cause an influx of these lines in the logs
There was a problem hiding this comment.
I don't think so, once per minute when app in foreground
BamMironov
approved these changes
Jul 22, 2024
anq83
force-pushed
the
M2-7137-autocompletion_ph2_delivery_part_3
branch
from
8f0ca87
to
e3a0db7
Compare
…e-use layout from blocker screens ; M2-6958: [Mobile]: Implement UI components for displaying progress ; M2-6960: [Mobile]: Integrate progress tracking into Finish/Interim screens ; M2-6959: [Mobile]: Integrate progress tracking into autocompletion blocker-progress screens ; M2-6949: [Mobile]: Implement App-level timer and hook which will call auto completion services ; PR Fixes ;
anq83
force-pushed
the
M2-7137-autocompletion_ph2_delivery_part_3
branch
from
e3a0db7
to
a194600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-7137
Changes include:
📸 Screenshots