Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-6962, M2-6963, M2-6964, M2-6956, M2-6952: Refactor check entity availability, etc., delivery: part 1 #797

Closed

Conversation

anq83
Copy link
Contributor

@anq83 anq83 commented Jun 10, 2024

📝 Description

🔗 Jira Ticket M2-6962
🔗 Jira Ticket M2-6963
🔗 Jira Ticket M2-6964
🔗 Jira Ticket M2-6956
🔗 Jira Ticket M2-6952

Autocompletion, phase # 2, delivery # 1

Changes include:

  • Check entity avaiability is rewritten, now we use evaluators directly, i.o. groups-builders
  • Evaluators adopted for usage them directly
  • Fixes related unit-tests
  • Refactored useStartEntity to return more crisp result
  • Added new triggers: activity closed, app goes to foreground
  • Refactored/extended RootNavigator to support all this
  • Added Activity-level availability timer and related hook

@anq83 anq83 marked this pull request as draft June 10, 2024 15:05
@anq83 anq83 force-pushed the M2-6962-Refactor-checkEntityAvailability_etc_deliver-part-1 branch 4 times, most recently from 580913b to 2e0d2b5 Compare June 12, 2024 09:50
@anq83 anq83 changed the title M2-6962: Refactor check entity availability, etc., delivery: part 1 M2-6962, M2-6963, M2-6964, M2-6956, M2-6952: Refactor check entity availability, etc., delivery: part 1 Jun 14, 2024
@anq83 anq83 marked this pull request as ready for review June 14, 2024 15:21
…ators directly, trigger blocker screen on alert's OK button modify useStartEntity hook ;

M2-6956: [Mobile]: Add activity-progress-level timer and extend infrastructure for autocompletion executing activity/flow when it's availability time is over. ;
M2-6952: [Mobile]: Extend CollectCompletionsService: add check if any completion exist, integrate it. ;
M2-6964: [Mobile:] Trigger autocompletion when activity is closed by user ;
M2-6963: [Mobile]: Trigger autocompletion when app goes to foreground from background ;
@anq83 anq83 force-pushed the M2-6962-Refactor-checkEntityAvailability_etc_deliver-part-1 branch from 3d7959d to 27be798 Compare June 18, 2024 11:13
@anq83
Copy link
Contributor Author

anq83 commented Jun 18, 2024

The PR #806
contains all these changes and based on the actual dev,
so close this one as outdated

@anq83 anq83 closed this Jun 18, 2024
@anq83 anq83 deleted the M2-6962-Refactor-checkEntityAvailability_etc_deliver-part-1 branch June 25, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant