-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicall V2.5 implementation #624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ChainSafe.Gaming/ChainSafe.Gaming.csproj # src/ChainSafe.Gaming/Web3/Core/Build/Web3Builder.cs # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scenes/SampleMain.unity # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Prefabs/MultiCall.meta # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Prefabs/MultiCall/MultiCall.cs # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Prefabs/MultiCall/MultiCall.cs.meta # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/MultiCall.meta # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/MultiCall/MultiCallErc20Behavior.cs # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/MultiCall/MultiCallErc20Behavior.cs.meta
auto-assign
bot
requested review from
juans-chainsafe,
kalambet,
kantagara and
oleksandrchainsafe
October 11, 2023 16:05
robGG1997
suggested changes
Oct 16, 2023
Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scripts/Prefabs/MultiCall/MultiCall.cs
Outdated
Show resolved
Hide resolved
Packages/io.chainsafe.web3-unity/Runtime/Scripts/Samples/MultiCallSample.cs
Show resolved
Hide resolved
# Conflicts: # Packages/io.chainsafe.web3-unity.lootboxes/Chainlink/Runtime/Libraries/Chainsafe.Gaming.Chainlink.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Chainlink.Lootboxes.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Debugging.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Gelato.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.InProcessSigner.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.InProcessTransactionExecutor.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Unity.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.WebPageWallet.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.dll
kantagara
reviewed
Oct 26, 2023
...ssets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Prefabs/MultiCall/MultiCall.cs
Outdated
Show resolved
Hide resolved
sneakzttv
approved these changes
Oct 31, 2023
kantagara
approved these changes
Nov 1, 2023
# Conflicts: # Packages/io.chainsafe.web3-unity.lootboxes/Chainlink/Runtime/Libraries/ChainSafe.Gaming.Lootboxes.Chainlink.dll # Packages/io.chainsafe.web3-unity.lootboxes/Chainlink/Runtime/Libraries/Chainsafe.Gaming.Chainlink.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Debugging.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Gelato.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.InProcessSigner.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.InProcessTransactionExecutor.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Unity.ThirdParty.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.Unity.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.WalletConnect.dll # Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.dll # Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scenes/SampleMain.unity # Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scripts/Scenes/Login.cs # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scenes/SampleMain.unity # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/Login.cs
robGG1997
approved these changes
Nov 2, 2023
robGG1997
added a commit
that referenced
this pull request
Nov 3, 2023
* Cherry picked * Added refrerences * Cherry picked DTO files * Added config * Auto-duplicate Package Samples * Connecting to unity buttons * Auto-duplicate Package Samples * Function triggering * Trying to get call data to be accepted * Refactored to contract style * No idea how to get logic in to unity * Saved unity files * Finally referenced in the game * Attempting to init packages * Pushing for support * ambiguous method compile error and MultiCall already bound runtime error fixed * ProjectConfig returning bool * Works without multicall again * Calls are successful, return decode, not so much * Results returned as expected * Fixed merge, scripts still broken * Auto-duplicate Package Samples * retrigger checks * Updated comments * rebuilt & removed file again * Auto-duplicate Package Samples * Rebuilt * Lint fix * Rebuilt --------- Co-authored-by: RyRy79261 <RyRy79261@users.noreply.github.com> Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Peter Kalambet <peter@kalambet.dev>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Cherry picked * Added refrerences * Cherry picked DTO files * Added config * Auto-duplicate Package Samples * Connecting to unity buttons * Auto-duplicate Package Samples * Function triggering * Trying to get call data to be accepted * Refactored to contract style * No idea how to get logic in to unity * Saved unity files * Finally referenced in the game * Attempting to init packages * Pushing for support * ambiguous method compile error and MultiCall already bound runtime error fixed * ProjectConfig returning bool * Works without multicall again * Calls are successful, return decode, not so much * Results returned as expected * Fixed merge, scripts still broken * Auto-duplicate Package Samples * retrigger checks * Updated comments * rebuilt & removed file again * Auto-duplicate Package Samples * Rebuilt * Lint fix * Rebuilt --------- Co-authored-by: RyRy79261 <RyRy79261@users.noreply.github.com> Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Peter Kalambet <peter@kalambet.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #484