feat: add devnet-5 support #7246
Open
+1,265
−456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7246 +/- ##
============================================
- Coverage 48.76% 48.62% -0.15%
============================================
Files 601 603 +2
Lines 40243 40507 +264
Branches 2067 2071 +4
============================================
+ Hits 19626 19697 +71
- Misses 20579 20772 +193
Partials 38 38 |
ensi321
force-pushed
the
devnet-5
branch
2 times, most recently
from
7ae5f0f to
324562a
Compare
* feat: refactor SeenAttestationDatas for SinlgeAttestation * feat: add SingleAttestation type * feat: ssz utils for SingleAttestation * feat: implement SingleAttestation for network processor and gossip queue * fix: add SingleAttestation for phase0 and altair * fix: define and publish SingleAttestation for all forks * Fix electra SingleAttestation type mapping * Update api and eventstream * Update validator client * Update attestation unit test variables * chore: SeenAttestationDatas unit tests * chore: sszBytes unit tests * Use CommitteeIndex type * refactor: get/set functions of SeenAttestationDatas * Always emit single_attestation event * Validation use new SeenAttDataKey * validateAttestationNoSignatureCheck first draft * Add aggregation and committee bits to cache * AttestationPool accepts SingleAttestation * Update SingleAttestation event stream * Update aggregate validation * Polish * Lint * fix check-types * Remove committee bit cache * Update attestation pool unit tests * Lint * Remove unused committeeBits from attestation data cache * Fix spec reference comment * fix: getSeenAttDataKeyFromSignedAggregateAndProof * Update beacon-api spec tests to run against v3.0.0-alpha.9 --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>
…7256) * fix: select correct gossip type when publishing single attestation * Add SingleAttestation as alias to phase0 ssz types
* fix: remove aggregation bits from seen attestation cache * Allow passing null as aggregationBits to test pre-electra case * Only create aggregationBits once for the first attestation * Avoid second getSingleTrueBit call
…#7261) * fix: return correct type from attestation validation when using cache * Remove type casts * Remove unused import * Use ternary operator instead of if-else * Fix aggregationBits type issue * Add comment
* initial commit * Address comment * Lint
* Rename PartialPendingWithdrawal field * do not change creds type on consolidation * Use validator EB to process pending consolidation * lint
* Fix execution request parsing * lint * Rename type --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
…685 (#7330) * test: ensure execution requests are de-/serialized according to EIP-7685 * Fix format * Add test case where deposits, withdrawals and consolidations are all empty * Remove map
* Init * Add reqresp v2 definition * Update validateGossipBlock * Partial commit * Reqresp. Add todos * polish * Fork-aware requestSszTypeByMethod * Fixed minimal constants * Bump config test version * Update blob sidecar subnet computation * Pass proper commitment limit to block gossip error * Update blob sidecar index check * Lint * Update kzg unit test * Subscribe to correct number of blob sidecar subnets * Refactor constants getter to constantsHelper * address comment * Pass fork as first arg * Update packages/state-transition/src/block/processExecutionPayload.ts * refactor: move helper to get max blobs per block to fork config (#7322) * Simplify type cast --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
|
Version bump merged for inclusion: ethereum/consensus-specs#4077 |
fix: use Bigint for deposit index
chore: skip fulu spec tests
* fix: revert BlobSidecarsByRoot/Range version bump * Remove version check from handler * Remove unused imports
|
need to make sure to forward merge this branch |
* chore: update lighthouse to latest unstable version * Remove unsupported CLI flags * Update to deposit_contract_block.txt * Update to deposit_contract_block.txt for validator
nflaig
added
the
status-do-not-merge
wemeetagain
reviewed
Jan 15, 2025
| @@ -85,6 +85,7 @@ export function validateBeaconBlocksByRangeRequest( | |||
| // step > 1 is deprecated, see https://github.com/ethereum/consensus-specs/pull/2856 | |||
|
|
|||
| if (count > MAX_REQUEST_BLOCKS) { | |||
| // TODO: This is probably not right as `BeaconBlocksByRangeV2` takes at most `MAX_REQUEST_BLOCKS_DENEB` | |||
There was a problem hiding this comment.
should this fn take a fork parameter?
There was a problem hiding this comment.
need to review this but it does not seem correct as is
There was a problem hiding this comment.
should this fn take a fork parameter?
It is just a random thing I found when coding EIP-7691. Has nothing to do with devnet-5 so added TODO instead.
There was a problem hiding this comment.
there are missing changes for devnet-5, see #7368, while this will likely not be an issue we should probably update it as part of this branch
* Remove stale todo * some refactoring * Readd comment, seems somewhat useful * Add alias for getSlotFromOffset * Use parseInt instead of Number * Update return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.