Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert BlobSidecarsByRoot/Range version bump #7347

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jan 10, 2025

There is no need to bump the version to v2 (ethereum/consensus-specs#4077)

@nflaig nflaig requested a review from a team as a code owner January 10, 2025 09:09
@nflaig nflaig marked this pull request as draft January 10, 2025 09:14
@nflaig nflaig marked this pull request as ready for review January 10, 2025 09:21
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.62%. Comparing base (cf64359) to head (eac1ac1).
Report is 3 commits behind head on devnet-5.

Additional details and impacted files
@@            Coverage Diff            @@
##           devnet-5    #7347   +/-   ##
=========================================
  Coverage     48.61%   48.62%           
=========================================
  Files           603      603           
  Lines         40534    40507   -27     
  Branches       2071     2071           
=========================================
- Hits          19707    19697   -10     
+ Misses        20789    20772   -17     
  Partials         38       38           

@nflaig
Copy link
Member Author

nflaig commented Jan 10, 2025

Passing beta.0 spec tests + confirmed this works on kurtosis with Prysm and Teku

@ensi321 ensi321 merged commit 8e423e7 into devnet-5 Jan 10, 2025
13 of 17 checks passed
@ensi321 ensi321 deleted the nflaig/revert-reqresp-v2 branch January 10, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants