Save and use full LightClientUpdate instead of partial #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Oct 29, 2022
packages/db/src/schema.ts
Outdated
| @@ -60,7 +60,7 @@ export enum Bucket { | |||
| lightClient_syncCommittee = 52, // Root(altair.SyncCommittee) -> altair.SyncCommittee | |||
| // TODO: May be redundant to block stores | |||
| lightClient_checkpointHeader = 53, // BlockRoot -> phase0.BeaconBlockHeader | |||
| lightClient_bestPartialLightClientUpdate = 54, // SyncPeriod -> PartialLightClientUpdate | |||
| lightClient_bestLightClientUpdate = 54, // SyncPeriod -> LightClientUpdate | |||
There was a problem hiding this comment.
Should we use a new bucket for a non-errored migration?
g11tech
changed the title
wemeetagain
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous scheme of things, the sync committee branch corresponding to finalized checkpoint's state was fetched and bundled, but that shifted from finalized checkpoints state to the attested header's state.
But the non checkpoint syncComitteeWitness data gets pruned later and hence the best partial update was no more servicable causing broken get update api.
This PR fixes by storing the full update instead of partial because all corresponding data is available while storing the update, so that the data availability doesn't become the issue post pruning.
Console log of the light client demo which can now properly process the lightclient updates to sync to the current (the new url fetch errors are because of the latest merged p2p PR which might have updated some routes, the light client demo to be independently updated)