-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken API endpoint /eth/v1/beacon/light_client/updates #4574
Comments
The endpoint returns successful using a beacon node as shown below... using any period from 290 till 581 (the current period)
@zsfelfoldi Can you confirm from your end? I also noticed the url you shared has the period has 10, which is wrong...can you confirm also with a correct period. Also if the issue persist, when you start the node before you make the request, do you observe any errors in the logs you can share that can help debug the issue? |
@dadepo as I wrote my node is running Sepolia on which period 10 should be valid. It looks to me like the updates generated since the node was started are returned fine but if I stop and restart the node it returns the error for those periods too (in case of my Sepolia node periods 81 to 85 are working because it was last started before generating update 81). So there is something that works while in memory but the db store and/or retrieval is wrong. |
Hi @zsfelfoldi I'll update you once a fix is available. |
@dadepo I think I'm one step closer to the issue now. When I tried to verify those updates that are returned (that were generated since the node startup) I realized that they are wrong too, at least when they have a finalized header. In this case the finalized header's block root should be proven by the finality branch starting from the main header's state root (this part is correct) and the next sync committee root should be proven by the next sync committee branch, starting from the finalized header's state root. This latter part is not correct, now this proof is also rooted in the main header's state root (making the finalized header pointless). This was also correct earlier so maybe this is where something got broken and the two issues might be related. |
Looks like this issue has been solved by #4702 |
The
updates
endpoint seems to be broken:http://104.248.139.137:9596/eth/v1/beacon/light_client/updates?start_period=10&count=1 returns {"statusCode":500,"error":"Internal Server Error","message":"finalizedBlockRoot not available 0xc23381411ab2aee8a7aa9dc63ebe7faac3220fe53582c03051e5879fb90ecfec"}
(the node on the given address runs Sepolia but I have tried it with another node running Mainnet too and it returns the same error for any period between the Altair fork and the latest period)
The text was updated successfully, but these errors were encountered: