Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): implement Filecoin.StateListActors #4409

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jun 12, 2024

Summary of changes

Changes introduced in this pull request:

  • implement RPC method Filecoin.StateListActors
  • API compare tests
     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-06-12_height_1694998.forest.car.zst --filter StateListActors`
| RPC Method                    | Forest | Lotus |
|-------------------------------|--------|-------|
| Filecoin.StateListActors (10) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review June 12, 2024 07:28
@hanabi1224 hanabi1224 requested a review from a team as a code owner June 12, 2024 07:28
@hanabi1224 hanabi1224 requested review from ruseinov and sudo-shashank and removed request for a team June 12, 2024 07:28
@ruseinov ruseinov self-requested a review June 12, 2024 14:06
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a CHANGELOG entry.

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Jun 13, 2024

Missing a CHANGELOG entry.

@ruseinov I'd prefer not to bloat the changelog(and create potential merge conflicts with others) with an entry for each individual RPC method, maybe better to use a milestone entry instead. Note that we still have the detailed autogenerated changelog for each PR on the release page. Echoing @lemmih 's comment here

I'm okay with not having a changelog entry for each RPC method. Instead, we'll have an entry for each RPC milestone (full v0, full v1, full lotus compliance, etc).

@ruseinov
Copy link
Contributor

ruseinov commented Jun 13, 2024

Missing a CHANGELOG entry.

@ruseinov I'd prefer not to bloat the changelog(and create potential merge conflicts with others) with an entry for each individual RPC method, maybe better to use a milestone entry instead. Note that we still have the detailed autogenerated changelog for each PR on the release page. Echoing @lemmih 's comment here

I'm okay with not having a changelog entry for each RPC method. Instead, we'll have an entry for each RPC milestone (full v0, full v1, full lotus compliance, etc).

I mean we used to put every RPC endpoint into CHANGELOG till now, I see no reason in changing that now.
I leave this up to you, I find changing patterns confusing, especially since we've already introduced most of the endpoints.

@ruseinov ruseinov self-requested a review June 13, 2024 08:55
@aatifsyed aatifsyed added this pull request to the merge queue Jun 14, 2024
@aatifsyed aatifsyed removed this pull request from the merge queue due to a manual request Jun 14, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue Jun 15, 2024
Merged via the queue into main with commit 704e2ec Jun 15, 2024
27 checks passed
@hanabi1224 hanabi1224 deleted the hm/StateListActors branch June 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants