Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): implement Filecoin.NetAutoNatStatus #4039

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Mar 7, 2024

Summary of changes

Changes introduced in this pull request:

  • implement Filecoin.NetAutoNatStatus
     Running `target/debug/forest-tool api compare --filter NetAuto`
| RPC Method                | Forest | Lotus |
|---------------------------|--------|-------|
| Filecoin.NetAutoNatStatus | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review March 7, 2024 12:59
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 7, 2024 12:59
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and aatifsyed and removed request for a team March 7, 2024 12:59
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an entry in the changelog?

@lemmih
Copy link
Contributor

lemmih commented Mar 7, 2024

Should there be an entry in the changelog?

I'm okay with not having a changelog entry for each RPC method. Instead, we'll have an entry for each RPC milestone (full v0, full v1, full lotus compliance, etc).

@hanabi1224 hanabi1224 added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 9230848 Mar 7, 2024
30 checks passed
@hanabi1224 hanabi1224 deleted the hm/net-auto-nat-status branch March 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants