feat(rpc): implement MpoolSelect
#4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
hanabi1224 and
aatifsyed
and removed request for
a team
|
The newly exposed code could use a lot of love. |
aatifsyed
approved these changes
Apr 17, 2024
| @@ -1,6 +1,6 @@ | |||
| // Copyright 2019-2024 ChainSafe Systems | |||
| // SPDX-License-Identifier: Apache-2.0, MIT | |||
|
|
|||
| #![allow(clippy::indexing_slicing)] | |||
There was a problem hiding this comment.
I'd rather see documented unwraps
There was a problem hiding this comment.
Me too. I opened a new tracking issue: #4229
| @@ -6,6 +6,7 @@ | |||
| //! `select_messages` API which selects an appropriate set of messages such that | |||
| //! it optimizes miner reward and chain capacity. See <https://docs.filecoin.io/mine/lotus/message-pool/#message-selection> for more details | |||
|
|
|||
| #![allow(clippy::indexing_slicing)] | |||
hanabi1224
reviewed
Apr 17, 2024
| pub enum MpoolSelect {} | ||
| impl RpcMethod<2> for MpoolSelect { | ||
| const NAME: &'static str = "Filecoin.MpoolSelect"; | ||
| const PARAM_NAMES: [&'static str; 2] = ["tsk", "tq"]; |
There was a problem hiding this comment.
Should we use full words, tipset_key and, what is tq?
There was a problem hiding this comment.
Other commands also use 'tsk'. Not sure what tq means. I blatantly copied it from Lotus. Hopefully, we can fix it once we understand what these RPC methods should do.
hanabi1224
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
select_messages, which was hidden behind#[cfg(test)].MpoolSelectagainst Lotus.Reference issue to close (if applicable)
Closes #4196
Other information and links
Change checklist