Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe indexing from src/message_pool/msg_chain.rs and src/message_pool/msgpool/selection.rs #4229

Closed
2 tasks
lemmih opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
Priority: 4 - Low Limited impact and can be implemented at any time Ready Issue is ready for work and anyone can freely assign it to themselves

Comments

@lemmih
Copy link
Contributor

lemmih commented Apr 17, 2024

Issue summary

Both src/message_pool/msg_chain.rs and src/message_pool/msgpool/selection.rs had code untouched for years. Now we're using the code again, which needs some love/cleaning. The modules have a lot of unsafe indexing, and they allow clippy::indexing_slicing.

Tasks:

  • Remove #![allow(clippy::indexing_slicing)] from src/message_pool/msg_chain.rs.
  • Remove #![allow(clippy::indexing_slicing)] from src/message_pool/msgpool/selection.rs.

Other information and links

@lemmih lemmih added Priority: 4 - Low Limited impact and can be implemented at any time Ready Issue is ready for work and anyone can freely assign it to themselves labels Apr 17, 2024
@elmattic elmattic self-assigned this Jun 12, 2024
@lemmih
Copy link
Contributor Author

lemmih commented Aug 2, 2024

Not worth our time atm.

@lemmih lemmih closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 4 - Low Limited impact and can be implemented at any time Ready Issue is ready for work and anyone can freely assign it to themselves
Projects
None yet
Development

No branches or pull requests

2 participants