Fix combination beaker names and hosts #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci-linchpin-messageBus-trigger build #582: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/582/ |
|
Can one of the admins verify this patch? |
Previously, each name was combined with each host. This fixes the function so that each name is paired with the corresponding host Signed-off-by: Ryan Cole <rycole@redhat.com>
14rcole
force-pushed
the
beaker-deduplication
branch
from
5254ebb to
5bb7cf6
Compare
|
@14rcole Could you add sample unit test with mock data to check if works or not ? |
|
@p3ck @samvarankashyap ptal |
|
@samvarankashyap sorry, I didn't see your comment. I can. This would fall under #798 though, should I just put the unit test in there with the rest or slip it in here? |
|
ci-linchpin-messageBus-trigger build #585: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/585/ |
|
You can group it with others |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each name was combined with each host. This fixes the function so that each name is paired with the corresponding host