-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layout templating #582
Conversation
Remove the @ if necessary
Data parser will strip the @ as needed.
1773e18
to
dcdd513
Compare
ci-linchpin-messageBus-trigger build #98: SUCCESS: https://jenkins-continuous-infra.cloud.rhel8.upshift.engineering.redhat.com/job/ci-linchpin-messageBus-trigger/98/ |
[test] |
ci-linchpin-messageBus-trigger build #101: SUCCESS: https://jenkins-continuous-infra.cloud.rhel8.upshift.engineering.redhat.com/job/ci-linchpin-messageBus-trigger/101/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide the output of the test cases.
Thanks
Testing proof this works.
These next lines show how the 'fedora26' distro was included to make the test successful.
These next lines show how the 'fedora26' distro was included to make the test successful.
|
@p3ck just making sure you have seen the tests above and are comfortable with merging this PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the test cases as part of this commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Just wanted to make sure it doesn't get lost
[merge] |
Adjusted the dataparser.process function to treat all data as a potential file. It checks now for a leading '@' and reads the file into data before continuing. The inventory_layout templating was failing because it wasn't passing any values along.
Fixes #584