Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub documentation and templates #890

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

speth
Copy link
Member

@speth speth commented Jul 1, 2020

Changes proposed in this pull request

  • Update references to the default branch, now named main
  • Change order of fields in the PR template (put the description of changes above the checklist)
  • Revise the Issue template to emphasize providing the "steps to reproduce" and deemphasize describing "expected behavior" (which I felt encouraged unintentionally abrasive and unhelpful problem descriptions akin to "the program runs and does not crash").

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@f1646a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage        ?   70.50%           
=======================================
  Files           ?      375           
  Lines           ?    45685           
  Branches        ?        0           
=======================================
  Hits            ?    32210           
  Misses          ?    13475           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1646a6...82261b5. Read the comment docs.

@bryanwweber
Copy link
Member

These changes should probably also be made in .github/workflows/main.yml, although the CI appears to have run anyways...

@speth
Copy link
Member Author

speth commented Jul 1, 2020

Did I miss something? There are several changes to .github/workflows/main.yml in this PR. I guess the only thing that doesn't reflect this is the PR title...

@ischoegl
Copy link
Member

ischoegl commented Jul 1, 2020

CI is no longer triggered after pushing changes to branches previously set up to be merged into master ... see current status of #888

@bryanwweber
Copy link
Member

@speth Sorry, I must have missed the changes before I commented!

@ischoegl That's not unexpected, the CI is only triggered for pull requests to master, but the PRs are going to main now. This PR should fix that.

@speth speth merged commit 2fc94be into Cantera:main Jul 1, 2020
@ischoegl
Copy link
Member

ischoegl commented Jul 1, 2020

@bryanwweber ... 👍 confirmed. I was just puzzled as CI had been triggered on this PR (which I assumed was after the renaming).

@bryanwweber
Copy link
Member

@ischoegl I'm guessing caching (it's always caching 😄 )

@speth speth deleted the docs-and-templates branch July 1, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants