Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gitignore #888

Closed
wants to merge 2 commits into from
Closed

Simplify gitignore #888

wants to merge 2 commits into from

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jun 30, 2020

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

If applicable, fill in the issue number this pull request is fixing

  • In Improve error message for missing phases key #880 renamed executables were excluded in the main .gitignore file (rather than test_problems/.gitignore)
  • Hidden .gitinore files in subfolders are hard to locate / easy to overlook
  • Merge test_problems/.gititnore (and others) into .gitignore
  • Use include overrides in addition to exclude directives to declutter

Changes result in a reduction of gitignore instructions by half

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #888 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #888   +/-   ##
=======================================
  Coverage   71.11%   71.11%           
=======================================
  Files         376      376           
  Lines       46201    46201           
=======================================
  Hits        32858    32858           
  Misses      13343    13343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dac7b...3287b40. Read the comment docs.

@ischoegl ischoegl changed the title Fix gitignore Simplify gitignore Jun 30, 2020
@speth speth changed the base branch from master to main June 30, 2020 23:15
- merge test_problems/.gitignore with main file
- use exclude/include lists to declutter
- Move all .gitignore instructions to a single file
- Simplify files via exclusion/inclusion syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant