Use Cantera Error in leftover examples #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanwweber
requested changes
Feb 17, 2019
There was a problem hiding this comment.
Thanks @CyberDrudge I restarted the failing build because I think it was a problem with the CodeCov service, not with anything you did here. A few changes below!
interfaces/cython/cantera/examples/onedim/diffusion_flame_batch.py
Outdated
Show resolved
Hide resolved
interfaces/cython/cantera/examples/onedim/diffusion_flame_extinction.py
Outdated
Show resolved
Hide resolved
CyberDrudge
force-pushed
the
updateExceptions
branch
from
ded7856
to
27c790c
Compare
|
I applied the suggested changes and squashed the commits. |
bryanwweber
approved these changes
Feb 17, 2019
Update diffusion_flame_batch.py and diffusion_flame_extinction.py to use CanteraError where appropriate. Define a new FlameExtinguished exception to distinguish between extinction and other failures. This allows things like OSErrors to still be raised to the user while dealing with exceptions we can handle. Closes Cantera#569.
bryanwweber
force-pushed
the
updateExceptions
branch
from
27c790c
to
aa9721d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Implemented use of CanteraError in examples diffusion_flame_extinction.py and diffusion_flame_batch.py