Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of m_spthermo in VPStandardStateTP #588

Merged
merged 4 commits into from
Jan 23, 2019

Commits on Jan 11, 2019

  1. [Thermo] Clean up implementation of MaskellSolidSolnPhase

    Eliminate several member variables which shadow variables of the
    VPStandardState class, and actually contained the same information
    calculated a different way.
    speth committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    5f22021 View commit details
    Browse the repository at this point in the history
  2. [Thermo] Allow species without thermo data

    In some models, SpeciesThermoInterpType objects on individual species are not
    used. Instead of requiring the specification of placeholder thermo data, this
    allows the base SpeciesThermoInterpType class to be used, which will throw an
    exception if it is inadvertently used.
    speth committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    0714822 View commit details
    Browse the repository at this point in the history
  3. [Thermo] VPStandardStateTP does not use reference thermo objects

    Since VPStandardStateTP and derived classes do not use the reference state
    thermodynamic properties in the m_spthermo object, we can just install
    placeholder objects there, and eliminate the wrapper clas STITbyPDSS.
    speth committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    d573aea View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. [Thermo] Fix incorrect documentation in the PDSS class

    PDSS objects do not interact with the MultiSpeciesThermo object for a phase,
    but at most a single SpeciesThermoInterpType object.
    speth committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    83b67c1 View commit details
    Browse the repository at this point in the history