Remove unnecessary use of m_spthermo in VPStandardStateTP #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate several member variables which shadow variables of the VPStandardState class, and actually contained the same information calculated a different way.
In some models, SpeciesThermoInterpType objects on individual species are not used. Instead of requiring the specification of placeholder thermo data, this allows the base SpeciesThermoInterpType class to be used, which will throw an exception if it is inadvertently used.
Since VPStandardStateTP and derived classes do not use the reference state thermodynamic properties in the m_spthermo object, we can just install placeholder objects there, and eliminate the wrapper clas STITbyPDSS.
PDSS objects do not interact with the MultiSpeciesThermo object for a phase, but at most a single SpeciesThermoInterpType object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPStandardStateTPand its derived classes use a method for handling individual species thermo properties which does not involve the use of them_spthermoobject inherited from classThermoPhase. By eliminating the few instances where them_spthermoobject was being used inVPStandardStateTP, we are able to simplify things quite a bit. The main advantages are:STITbyPDSSwrapper class unnecessary