Use normal sign convention for reactor heat transfer #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heat transfer into a system is normally considered positive. The sign convention from the perspective of a wall between two reactors is unchanged, with a positive value indicating heat transfer from the left to the right.
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 370 370
Lines 48983 48984 +1
=======================================
+ Hits 36133 36134 +1
Misses 12850 12850
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heat transfer into a system is normally considered positive, and the internal variables used within
Reactorshould reflect this convention.This does not change the sign convention from the perspective of a wall between two reactors is unchanged, where a positive value indicates heat transfer from the left to the right, which I think is consistent.
Changes proposed in this pull request
Reactor::m_Qdotusing the updated sign convention, and use this to setReactor::m_Qfollowing the existing conventionReactor::m_Qdotin calculations for all reactor models instead ofm_QReactor::m_QThe
Reactor::m_Qvariable is aprotectedmember of theReactorclass, with no accessor, so this can only affect user-generated classes derived fromReactor. However, fixing this is important for #1003, which does introduce a getter/setter pair for this net heat transfer, and using the normal sign convention would prevent some surprising behavior.If applicable, fill in the issue number this pull request is fixing
Closes #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage