perf: Storing the JsonFile assets as byte[] instead of string

Assets/LDtkUnity/Editor/ScriptedImporter/LDtkJsonImporter.cs

@@ -319,8 +319,9 @@ internal abstract class LDtkJsonImporter<T> : LDtkJsonImporter where T : Scripta
     {
         protected T ReadAssetText()
         {
-            LDtkProfiler.BeginSample("ReadAllText");
-            string jsonText = File.ReadAllText(assetPath);
+            //todo don't need to read all bytes twice. pass in a previous FromJson
+            LDtkProfiler.BeginSample("ReadAllBytes");
+            byte[] jsonText = File.ReadAllBytes(assetPath);
             LDtkProfiler.EndSample();
 
             LDtkProfiler.BeginSample("ScriptableObject.CreateInstance");

Assets/LDtkUnity/Runtime/Data/Extensions/Level/Level.cs

@@ -14,7 +14,7 @@ public partial class Level : ILDtkUid, ILDtkIdentifier, ILDtkIid
         /// <returns>
         /// The deserialized level.
         /// </returns>
-        public static Level FromJson(string json)
+        public static Level FromJson(byte[] json)
         {
             return Utf8Json.JsonSerializer.Deserialize<Level>(json);
         }

Assets/LDtkUnity/Runtime/Data/Schema/LdtkJson.cs

@@ -295,6 +295,6 @@ public partial class LdtkJson
 
     public partial class LdtkJson
     {
-        public static LdtkJson FromJson(string json) => JsonSerializer.Deserialize<LdtkJson>(json);
+        public static LdtkJson FromJson(byte[] json) => JsonSerializer.Deserialize<LdtkJson>(json);
     }
 }

Assets/LDtkUnity/Runtime/UnityAssets/Json/ILDtkJsonFile.cs

@@ -2,6 +2,6 @@
 {
     internal interface ILDtkJsonFile
     {
-        void SetJson(string json);
+        void SetJson(byte[] json);
     }
 }

Assets/LDtkUnity/Runtime/UnityAssets/Json/LDtkJsonFile.cs

@@ -4,13 +4,13 @@
 namespace LDtkUnity
 {
     [ExcludeFromDocs]
-    public abstract class LDtkJsonFile<T> : ScriptableObject, ILDtkJsonFile //todo we really need to make this a TextAsset
+    public abstract class LDtkJsonFile<T> : ScriptableObject, ILDtkJsonFile
     {
-        [SerializeField] protected string _json; 
+        [SerializeField] protected byte[] _json; 
 
         public abstract T FromJson { get; }
 
-        public virtual void SetJson(string json)
+        public virtual void SetJson(byte[] json)
         {
             _json = json;
         }

Assets/LDtkUnity/Runtime/UnityAssets/Json/LDtkTilesetDefinitionWrapper.cs

@@ -24,7 +24,7 @@ public class LDtkTilesetDefinitionWrapper
         /// </summary>
         public TilesetDefinition Def;
 
-        public static LDtkTilesetDefinitionWrapper FromJson(string json)
+        public static LDtkTilesetDefinitionWrapper FromJson(byte[] json)
         {
             return JsonSerializer.Deserialize<LDtkTilesetDefinitionWrapper>(json);
         }